From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752838AbbJYI2y (ORCPT ); Sun, 25 Oct 2015 04:28:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33667 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbbJYI2s (ORCPT ); Sun, 25 Oct 2015 04:28:48 -0400 Date: Sat, 24 Oct 2015 18:57:30 -0700 From: Greg KH To: Paul Davies C Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lustre: obdclass: fix sparse warning Message-ID: <20151025015730.GA23417@kroah.com> References: <562b3318.c1bf440a.60511.242e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <562b3318.c1bf440a.60511.242e@mx.google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 24, 2015 at 12:58:20PM +0530, Paul Davies C wrote: > This patch fixes the following warnings given by the sparse: > > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:424:5: warning: symbol 'class_procfs_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c:460:5: warning: symbol 'class_procfs_clean' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:161:5: warning: symbol 'obd_sysctl_init' was not declared. Should it be static? > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:166:6: warning: symbol 'obd_sysctl_clean' was not declared. Should it be static? > > Signed-off-by: Paul Davies C > --- > drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 4 ++-- > drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) This doesn't apply to my staging-testing branch of staging.git. Please rebase and resend, if it is still needed. thanks, greg k-h