From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geliang Tang <geliangtang@163.com>
Cc: devel@driverdev.osuosl.org,
Mike Marciniszyn <infinipath@intel.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
Date: Sat, 24 Oct 2015 19:05:32 -0700 [thread overview]
Message-ID: <20151025020532.GA22888@kroah.com> (raw)
In-Reply-To: <7653f784da256d3424c84d2c743d660219d66499.1445175749.git.geliangtang@163.com>
On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote:
> sched.h header in ipath_*.c is now unnecessary, since I have added
> sched.h in ipath_kernel.h. So remove it.
Overall, it's best to split this type of thing out, don't "hide" .h
includes in another .h file, so I'm not going to take this patch, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2015-10-25 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 5:04 [PATCH] IB/hfi1: use TASK_COMM_LEN in hfi1_ctxtdata Geliang Tang
2015-10-09 5:04 ` [PATCH] IB/ipath: use TASK_COMM_LEN in ipath_portdata Geliang Tang
2015-10-18 5:05 ` [PATCH] staging: " Greg Kroah-Hartman
2015-10-18 13:57 ` [PATCH v2 1/2] " Geliang Tang
2015-10-18 13:57 ` [PATCH v2 2/2] staging: IB/ipath: remove sched.h header Geliang Tang
2015-10-25 2:05 ` Greg Kroah-Hartman [this message]
2015-10-25 2:06 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025020532.GA22888@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=geliangtang@163.com \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).