From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752575AbbJZAMs (ORCPT ); Sun, 25 Oct 2015 20:12:48 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40990 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbbJZAMr (ORCPT ); Sun, 25 Oct 2015 20:12:47 -0400 Date: Mon, 26 Oct 2015 09:12:42 +0900 From: Greg KH To: Lijun Pan Cc: arnd@arndb.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, stuart.yoder@freescale.com, itai.katz@freescale.com, german.rivera@freescale.com, leoli@freescale.com, scottwood@freescale.com, agraf@suse.de, bhamciu1@freescale.com, R89243@freescale.com, bhupesh.sharma@freescale.com, nir.erez@freescale.com, richard.schmitt@freescale.com, dan.carpenter@oracle.com Subject: Re: [PATCH 2/5] staging: fsl-mc: define a macro to differentiate root dprc Message-ID: <20151026001242.GA20331@kroah.com> References: <1445812883-23551-1-git-send-email-Lijun.Pan@freescale.com> <1445812883-23551-3-git-send-email-Lijun.Pan@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445812883-23551-3-git-send-email-Lijun.Pan@freescale.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 25, 2015 at 05:41:20PM -0500, Lijun Pan wrote: > Define is_root_dprc(dev) to tell whether a device is > root dprc or not via platform_bus_type. > > Signed-off-by: Lijun Pan > --- > drivers/staging/fsl-mc/include/mc.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h > index a933291..483763e 100644 > --- a/drivers/staging/fsl-mc/include/mc.h > +++ b/drivers/staging/fsl-mc/include/mc.h > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > #include "../include/dprc.h" > > #define FSL_MC_VENDOR_FREESCALE 0x1957 > @@ -109,6 +110,15 @@ struct fsl_mc_resource { > #define FSL_MC_IS_DPRC 0x0001 > > /** > + * root dprc's parent is a platform device > + * that platform device's bus type is platform_bus_type. > + */ > +#define is_root_dprc(dev) \ > + ((to_fsl_mc_device(dev)->flags & FSL_MC_IS_DPRC) && \ > + ((dev)->bus == &fsl_mc_bus_type) && \ > + ((dev)->parent->bus == &platform_bus_type)) > + It's best to make this type of thing a static inline function, to ensure you get the correct typechecking. thanks, greg k-h