From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752899AbbJZR5y (ORCPT <rfc822;w@1wt.eu>);
	Mon, 26 Oct 2015 13:57:54 -0400
Received: from mail.kernel.org ([198.145.29.136]:38930 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751233AbbJZR5w (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 26 Oct 2015 13:57:52 -0400
Date: Mon, 26 Oct 2015 14:57:47 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Liang, Kan" <kan.liang@intel.com>
Subject: Re: [PATCH 03/52] perf tools: Add thread_map event
Message-ID: <20151026175747.GP27006@kernel.org>
References: <1445784728-21732-1-git-send-email-jolsa@kernel.org>
 <1445784728-21732-4-git-send-email-jolsa@kernel.org>
 <20151026174206.GN27006@kernel.org>
 <20151026174825.GO27006@kernel.org>
 <20151026175545.GA6855@krava.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151026175545.GA6855@krava.brq.redhat.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, Oct 26, 2015 at 06:55:45PM +0100, Jiri Olsa escreveu:
> On Mon, Oct 26, 2015 at 02:48:25PM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > > >  	u32 next_prev_tid;
> > > >  };
> > > >  
> > > > +struct thread_map_data_event {
> > > 
> > > Humm, I think "data" here is way too vague here, how about
> > > "thread_map_event_entry"?
> > > 
> > > Moving of "entry" to the end also helps in understanding that this is
> > > not an "event" per se, it doesn't have the perv_event_header, etc, its
> > > just an entry in a 'struct thread_map_event'.
> > > 
> > > I'm tentatively doing this change in my local branch, please let me know
> > > if you have any reason to object to such a change,
> > 
> > The resulting patch, that I'm merging with this one:
> 
> 
> seems ok, thanks

Thanks for checking, hopefully I can push this today.

- Arnaldo