From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbbJZWWL (ORCPT ); Mon, 26 Oct 2015 18:22:11 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34703 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbbJZWWJ (ORCPT ); Mon, 26 Oct 2015 18:22:09 -0400 Date: Mon, 26 Oct 2015 23:21:48 +0100 From: Bogicevic Sasa To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues Message-ID: <20151026222148.GA10647@gmail.com> References: <1445877415-8271-1-git-send-email-brutallesale@gmail.com> <20151026203620.GA15299@kroah.com> <20151026205555.GA9716@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20151026205555.GA9716@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26, Bogicevic Sasa wrote: >Thanks for the review just sent the new patch, >since change is very trivial I believe one liner like "fix all coding >style issues in that and that file" is descriptive enough. Don't know the >best practice so please be patient, I am new at this >On 10/27, Greg KH wrote: >>On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote: >>>Fixed coding style issues >>>Signed-off-by: Bogicevic Sasa >> >>What code style issues? Please be very specific. Also be sure you are >>only doing one "thing" per patch, and no, "fix all coding style issues" >>is not one thing... >> >>And we need a blank line before your signed-off-by: line. >> >>thanks, >> >>greg k-h