From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753309AbbJ0AJp (ORCPT ); Mon, 26 Oct 2015 20:09:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34070 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751399AbbJ0AJo (ORCPT ); Mon, 26 Oct 2015 20:09:44 -0400 Date: Tue, 27 Oct 2015 09:09:39 +0900 From: Greg KH To: Bogicevic Sasa Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues Message-ID: <20151027000939.GB30280@kroah.com> References: <1445877415-8271-1-git-send-email-brutallesale@gmail.com> <20151026203620.GA15299@kroah.com> <20151026205555.GA9716@gmail.com> <20151026222148.GA10647@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151026222148.GA10647@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: > On 10/26, Bogicevic Sasa wrote: > >Thanks for the review just sent the new patch, > >since change is very trivial I believe one liner like "fix all coding > >style issues in that and that file" is descriptive enough. No, not at all, that's not how we make kernel changes, look in the logs for specifics. Each patch needs to be descriptive and only do one thing. And as I said before "fix all coding style issues", is _NOT_ "one thing". Please break it up into logical patches, _AND_ use checkpatch.pl to properly send the patches to the correct mailing list and developers. thanks, greg k-h