From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbbJ0BMc (ORCPT ); Mon, 26 Oct 2015 21:12:32 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51884 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbbJ0BMa (ORCPT ); Mon, 26 Oct 2015 21:12:30 -0400 Date: Mon, 26 Oct 2015 18:12:29 -0700 From: Guenter Roeck To: Marc Titinger Cc: jdelvare@suse.com, lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] hwmon: ina2xx: convert driver to using regmap Message-ID: <20151027011229.GC31838@roeck-us.net> References: <562B7D56.3010700@roeck-us.net> <1445876673-32180-2-git-send-email-mtitinger@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445876673-32180-2-git-send-email-mtitinger@baylibre.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 26, 2015 at 05:24:32PM +0100, Marc Titinger wrote: > Any sysfs "show" read access from the client app will result in reading > all registers (8 with ina226). Depending on the host this can limit the > best achievable read rate. > > This changeset allows for individual register accesses through regmap. > > Tested with BeagleBone Black (Baylibre-ACME) and ina226. > > Signed-off-by: Marc Titinger Another comment: In ina2xx_calibrate, also use regmap_write(). Then you can drop the client variable in ina2xx_data. Thanks, Guenter