From: Greg KH <gregkh@linuxfoundation.org>
To: Punit Vara <punitvara@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
johnny.kim@atmel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()
Date: Tue, 27 Oct 2015 14:29:05 +0900 [thread overview]
Message-ID: <20151027052905.GA27242@kroah.com> (raw)
In-Reply-To: <1445889106-6737-1-git-send-email-punitvara@gmail.com>
On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
>
> -Prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara <punitvara@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 09a6c98..87b4eb8 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
> msg.drv = hif_drv;
>
> if (pu8MacAddr == NULL)
> - memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
> + eth_broadcast_addr(pstrDelStationMsg->mac_addr);
> else
> memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
>
Doesn't apply to my staging.git tree at all :(
prev parent reply other threads:[~2015-10-27 5:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 19:51 [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset() Punit Vara
2015-10-27 5:29 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027052905.GA27242@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johnny.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=punitvara@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).