From: Dan Carpenter <dan.carpenter@oracle.com>
To: "J. German Rivera" <German.Rivera@freescale.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
bhamciu1@freescale.com, jiang.liu@linux.intel.com,
bhupesh.sharma@freescale.com, agraf@suse.de,
stuart.yoder@freescale.com, nir.erez@freescale.com,
itai.katz@freescale.com, marc.zyngier@arm.com,
scottwood@freescale.com, lijun.pan@freescale.com,
leoli@freescale.com, R89243@freescale.com,
richard.schmitt@freescale.com
Subject: Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path
Date: Tue, 27 Oct 2015 13:04:07 +0300 [thread overview]
Message-ID: <20151027100407.GB7340@mwanda> (raw)
In-Reply-To: <1445874561-14761-9-git-send-email-German.Rivera@freescale.com>
On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote:
> -error_cleanup_open:
> +dprc_scan_container_error:
> (void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);
The error label was better in the original code. A "goto
error_cleanup_open", that tells you what the goto does. "goto
dprc_scan_container_error" tells you nothing because you can see from
the line before that there was a container error. No new information.
It's just like a function name tells you what a function does. You
wouldn't name the function called_from_main().
regards,
dan carpenter
next prev parent reply other threads:[~2015-10-27 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 15:49 [PATCH 00/10] staging: fsl-mc: MC bus MSI support J. German Rivera
2015-10-26 15:49 ` [PATCH 01/10] irqdomain: Added domain bus token DOMAIN_BUS_FSL_MC_MSI J. German Rivera
2015-10-26 15:49 ` [PATCH 02/10] staging: fsl-mc: Added generic MSI support for FSL-MC devices J. German Rivera
2015-10-27 7:28 ` Jiang Liu
2015-10-26 15:49 ` [PATCH 03/10] staging: fsl-mc: Added GICv3-ITS support for FSL-MC MSIs J. German Rivera
2015-10-26 15:49 ` [PATCH 04/10] staging: fsl-mc: Extended MC bus allocator to include IRQs J. German Rivera
2015-10-26 15:49 ` [PATCH 05/10] staging: fsl-mc: Changed DPRC built-in portal's mc_io to be atomic J. German Rivera
2015-10-26 15:49 ` [PATCH 06/10] staging: fsl-mc: Populate the IRQ pool for an MC bus instance J. German Rivera
2015-10-26 15:49 ` [PATCH 07/10] staging: fsl-mc: set MSI domain for DPRC objects J. German Rivera
2015-10-26 15:49 ` [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error path J. German Rivera
2015-10-27 10:04 ` Dan Carpenter [this message]
2015-10-26 15:49 ` [PATCH 09/10] staging: fsl-mc: Added DPRC interrupt handler J. German Rivera
2015-10-26 15:49 ` [PATCH 10/10] staging: fsl-mc: Added MSI support to the MC bus driver J. German Rivera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027100407.GB7340@mwanda \
--to=dan.carpenter@oracle.com \
--cc=German.Rivera@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@freescale.com \
--cc=jiang.liu@linux.intel.com \
--cc=leoli@freescale.com \
--cc=lijun.pan@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).