From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbbJ0LMU (ORCPT ); Tue, 27 Oct 2015 07:12:20 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37017 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754199AbbJ0LMR (ORCPT ); Tue, 27 Oct 2015 07:12:17 -0400 Date: Tue, 27 Oct 2015 12:12:01 +0100 From: Bogicevic Sasa To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging:drivers:wlan_ng: code style issues Message-ID: <20151027111201.GA5033@gmail.com> References: <1445877415-8271-1-git-send-email-brutallesale@gmail.com> <20151026203620.GA15299@kroah.com> <20151026205555.GA9716@gmail.com> <20151026222148.GA10647@gmail.com> <20151027000939.GB30280@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20151027000939.GB30280@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, I get it now, Ill will group all changes and resend the patches On 10/27/2015, Greg KH wrote: >On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: >> On 10/26, Bogicevic Sasa wrote: >> >Thanks for the review just sent the new patch, >> >since change is very trivial I believe one liner like "fix all coding >> >style issues in that and that file" is descriptive enough. > >No, not at all, that's not how we make kernel changes, look in the logs >for specifics. Each patch needs to be descriptive and only do one >thing. And as I said before "fix all coding style issues", is _NOT_ >"one thing". > >Please break it up into logical patches, _AND_ use checkpatch.pl to >properly send the patches to the correct mailing list and developers. > >thanks, > >greg k-h