From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753936AbbJ0GDJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 27 Oct 2015 02:03:09 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:36628 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753863AbbJ0GDH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 27 Oct 2015 02:03:07 -0400
Date: Tue, 27 Oct 2015 15:02:09 +0900
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mans Rullgard <mans@mansr.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr
Subject: Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800
 Ethernet controller
Message-ID: <20151027150209.043946d4@samsung9>
In-Reply-To: <1445895295-16778-2-git-send-email-mans@mansr.com>
References: <1445895295-16778-1-git-send-email-mans@mansr.com>
	<1445895295-16778-2-git-send-email-mans@mansr.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> +
> +static struct ethtool_ops nb8800_ethtool_ops = {
Ops should be const

> +	.get_settings		= nb8800_get_settings,
> +	.set_settings		= nb8800_set_settings,
> +	.nway_reset		= nb8800_nway_reset,
> +	.get_link		= ethtool_op_get_link,
> +};
> +

Since you are implementing ethtool please add a driver
info function.