From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755441AbbJ1GtZ (ORCPT ); Wed, 28 Oct 2015 02:49:25 -0400 Received: from mga14.intel.com ([192.55.52.115]:54316 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbbJ1GtY (ORCPT ); Wed, 28 Oct 2015 02:49:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,208,1444719600"; d="scan'208";a="589441346" Date: Wed, 28 Oct 2015 15:49:17 +0900 From: Vinod Koul To: Yao Yuan Cc: "stefan@agner.ch" , "arnd@arndb.de" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3] dmaengine: fsl-edma: add PM suspend/resume support Message-ID: <20151028064915.GD3041@vkoul-mobl.iind.intel.com> References: <1445243465-7727-1-git-send-email-yao.yuan@freescale.com> <20151027020035.GC11691@vkoul-mobl.iind.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2015 at 03:58:31AM +0000, Yao Yuan wrote: > Hi Vinod, > Please do not top post > Thanks for your review. > I did the test and it seems that it should be ok when CONFIG_PM is not defined. > So I removed the protection code to make it more readable. > Do you think is it ok? Yes I did check, this seems okay, pls ignore this comment. You still need to explain why you use late/early calls -- ~Vinod