From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbbJ1ROf (ORCPT ); Wed, 28 Oct 2015 13:14:35 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36670 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754929AbbJ1ROd (ORCPT ); Wed, 28 Oct 2015 13:14:33 -0400 Date: Wed, 28 Oct 2015 10:14:30 -0700 From: Brian Norris To: Boris Brezillon Cc: Marek Vasut , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Ezequiel Garcia , Scott Wood , Josh Wu , Robert Jarzmik , Kyungmin Park , Han Xu , Huang Shijie Subject: Re: [PATCH 1/5] mtd: ofpart: grab device tree node directly from master device node Message-ID: <20151028171430.GC13239@google.com> References: <1445913070-17950-1-git-send-email-computersforpeace@gmail.com> <20151027175446.GT13239@google.com> <20151028085813.4b0b3ac8@bbrezillon> <201510281711.14196.marex@denx.de> <20151028173215.0c1c4e30@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151028173215.0c1c4e30@bbrezillon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 28, 2015 at 05:32:15PM +0100, Boris Brezillon wrote: > On Wed, 28 Oct 2015 17:11:14 +0100 > Marek Vasut wrote: > > On Wednesday, October 28, 2015 at 08:58:13 AM, Boris Brezillon wrote: > > > Hi Brian, > > > > Hi, > > > > [...] > > > > > > Are > > > > there ever cases we want more than one (master) MTD per nand_chip? Or > > > > vice versa? > > > > > > Nope, I'd say that you always have a 1:1 relationship between a master > > > MTD device and a NAND device. > > > > Do some sorts of chipselects come into play here ? Ie. you can have one master > > with multiple NAND chips connected to it. > > Most NAND controllers support interacting with several chips (or > dies in case your chip embeds several NAND dies), but I keep thinking > each physical chip should have its own instance of nand_chip + mtd_info. > If you want to have a single mtd device aggregating several chips you > can use mtdconcat. > > This leaves the multi-dies chip case, and IHMO we should represent those > chips as a single entity, and I guess that's the purpose of the > ->numchips field in nand_chip (if your chip embeds 2 dies with 2 CS > lines, then ->numchips should be 2). Yes, I think that's some of the intention there. And so even in that case, a multi-die chip gets represented as a single struct nand_chip. Brian