From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757970AbbJ2VFq (ORCPT ); Thu, 29 Oct 2015 17:05:46 -0400 Received: from mx2.suse.de ([195.135.220.15]:48293 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbbJ2VFp (ORCPT ); Thu, 29 Oct 2015 17:05:45 -0400 Date: Thu, 29 Oct 2015 14:05:37 -0700 From: Davidlohr Bueso To: Jens Axboe Cc: Jeff Moyer , Steven Rostedt , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] blktrace: re-write setting q->blk_trace Message-ID: <20151029210537.GB7947@linux-uzut.site> References: <20151027030545.GH27292@linux-uzut.site> <20151027031452.GI27292@linux-uzut.site> <20151029191905.GA7947@linux-uzut.site> <56328152.9040001@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <56328152.9040001@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2015, Jens Axboe wrote: >Thanks, this is definitely cleaner. Your patch is still pretty >mangled, though. I had to hand apply it. Please check the result: > >http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.4/core&id=cdea01b2bf98affb7e9c44530108a4a28535eee8 Hmm I'm not sure what I'm doing wrong with the patch. This is the way I always send them through emacs... Sorry for the trouble, the commit above looks good (except the already mentioned eviewed tag :). Thanks, Davidlohr