From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758667AbbJ3GQv (ORCPT ); Fri, 30 Oct 2015 02:16:51 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33648 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758637AbbJ3GQr (ORCPT ); Fri, 30 Oct 2015 02:16:47 -0400 Date: Fri, 30 Oct 2015 14:16:43 +0800 From: Jiaxing Wang To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [for-next][PATCH 4/5] tracing: Check all tasks on each CPU when filtering pids Message-ID: <20151030061643.GA19480@cac> Mail-Followup-To: Steven Rostedt , linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton References: <20151029070754.584668951@goodmis.org> <20151029071032.334291716@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151029071032.334291716@goodmis.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2015 at 03:07:58AM -0400, Steven Rostedt wrote: > static ssize_t > ftrace_event_pid_write(struct file *filp, const char __user *ubuf, > size_t cnt, loff_t *ppos) > @@ -1711,6 +1727,12 @@ ftrace_event_pid_write(struct file *filp, const char __user *ubuf, > tr, INT_MAX); > register_trace_prio_sched_wakeup(event_filter_pid_sched_wakeup_probe_post, > tr, 0); > + > + /* > + * Ignoring of pids is done at task switch. But we have to > + * check for those tasks that are currently running. > + */ > + on_each_cpu(ignore_task_cpu, tr, 1); > } on_each_cpu(ignore_task_cpu, tr, 1); can be put outside of the else block, then ignore_pid can be updated when appending pid, eg. echo 'xxx' >> set_event_pid, in case xxx is running on some cpu. > > mutex_unlock(&event_mutex);