From: kbuild test robot <lkp@intel.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: kbuild-all@01.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>, Tejun Heo <tj@kernel.org>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/3] freezer: get rid of the kthread freezer
Date: Fri, 30 Oct 2015 22:08:49 +0800 [thread overview]
Message-ID: <201510302243.BOjZ7H2z%fengguang.wu@intel.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1510301440400.17538@pobox.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 4041 bytes --]
Hi Jiri,
[auto build test WARNING on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
url: https://github.com/0day-ci/linux/commits/Jiri-Kosina/PM-vfs-use-filesystem-freezing-instead-of-kthread-freezer/20151030-215223
config: x86_64-randconfig-x011-10300134 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/linux/fs.h:5:0,
from fs/jfs/jfs_txnmgr.c:45:
fs/jfs/jfs_txnmgr.c: In function 'jfs_lazycommit':
>> include/linux/wait.h:57:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
wait_queue_t name = __WAITQUEUE_INITIALIZER(name, tsk)
^
>> fs/jfs/jfs_txnmgr.c:2800:3: note: in expansion of macro 'DECLARE_WAITQUEUE'
DECLARE_WAITQUEUE(wq, current);
^
--
In file included from include/linux/mmzone.h:9:0,
from include/linux/gfp.h:5,
from include/linux/mm.h:9,
from include/linux/pagemap.h:7,
from fs/nilfs2/segment.c:24:
fs/nilfs2/segment.c: In function 'nilfs_segctor_thread':
include/linux/wait.h:935:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
wait_queue_t name = { \
^
>> include/linux/wait.h:941:27: note: in expansion of macro 'DEFINE_WAIT_FUNC'
#define DEFINE_WAIT(name) DEFINE_WAIT_FUNC(name, autoremove_wake_function)
^
>> fs/nilfs2/segment.c:2509:2: note: in expansion of macro 'DEFINE_WAIT'
DEFINE_WAIT(wait);
^
--
mm/vmscan.c: In function 'kswapd':
>> mm/vmscan.c:3454:8: warning: unused variable 'ret' [-Wunused-variable]
bool ret;
^
vim +/DECLARE_WAITQUEUE +2800 fs/jfs/jfs_txnmgr.c
^1da177e Linus Torvalds 2005-04-16 2784 sbi->commit_state &= ~IN_LAZYCOMMIT;
^1da177e Linus Torvalds 2005-04-16 2785 /*
^1da177e Linus Torvalds 2005-04-16 2786 * Don't continue in the for loop. (We can't
^1da177e Linus Torvalds 2005-04-16 2787 * anyway, it's unsafe!) We want to go back to
^1da177e Linus Torvalds 2005-04-16 2788 * the beginning of the list.
^1da177e Linus Torvalds 2005-04-16 2789 */
^1da177e Linus Torvalds 2005-04-16 2790 break;
^1da177e Linus Torvalds 2005-04-16 2791 }
^1da177e Linus Torvalds 2005-04-16 2792
^1da177e Linus Torvalds 2005-04-16 2793 /* If there was nothing to do, don't continue */
^1da177e Linus Torvalds 2005-04-16 2794 if (!WorkDone)
^1da177e Linus Torvalds 2005-04-16 2795 break;
^1da177e Linus Torvalds 2005-04-16 2796 }
^1da177e Linus Torvalds 2005-04-16 2797 /* In case a wakeup came while all threads were active */
^1da177e Linus Torvalds 2005-04-16 2798 jfs_commit_thread_waking = 0;
^1da177e Linus Torvalds 2005-04-16 2799
^1da177e Linus Torvalds 2005-04-16 @2800 DECLARE_WAITQUEUE(wq, current);
^1da177e Linus Torvalds 2005-04-16 2801
^1da177e Linus Torvalds 2005-04-16 2802 add_wait_queue(&jfs_commit_thread_wait, &wq);
^1da177e Linus Torvalds 2005-04-16 2803 set_current_state(TASK_INTERRUPTIBLE);
^1da177e Linus Torvalds 2005-04-16 2804 LAZY_UNLOCK(flags);
^1da177e Linus Torvalds 2005-04-16 2805 schedule();
^1da177e Linus Torvalds 2005-04-16 2806 remove_wait_queue(&jfs_commit_thread_wait, &wq);
91dbb4de Christoph Hellwig 2006-02-15 2807 } while (!kthread_should_stop());
^1da177e Linus Torvalds 2005-04-16 2808
:::::: The code at line 2800 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 27388 bytes --]
next prev parent reply other threads:[~2015-10-30 14:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 13:47 [PATCH 0/3] PM, vfs: use filesystem freezing instead of kthread freezer Jiri Kosina
2015-10-30 13:47 ` [PATCH 1/3] power, vfs: move away from PF_KTHREAD freezing in favor of fs freezing Jiri Kosina
2015-10-30 14:04 ` kbuild test robot
2015-10-31 8:55 ` Oliver Neukum
2015-11-02 3:01 ` Neil Brown
2015-11-02 7:54 ` yalin wang
2015-11-02 11:05 ` Jiri Kosina
2015-10-30 13:47 ` [PATCH 2/3] freezer: get rid of the kthread freezer Jiri Kosina
2015-10-30 14:08 ` kbuild test robot [this message]
2015-10-30 14:12 ` kbuild test robot
2015-10-30 13:48 ` [PATCH 3/3] freezer: warn if anyone is trying to use freezer on kthreads Jiri Kosina
2015-10-30 15:29 ` [PATCH 0/3] PM, vfs: use filesystem freezing instead of kthread freezer Alan Stern
2015-10-30 17:44 ` Pavel Machek
2015-10-30 19:40 ` Jiri Kosina
2015-10-30 20:41 ` Alan Stern
2015-10-30 21:17 ` Jiri Kosina
2015-10-31 3:15 ` Rafael J. Wysocki
2015-10-31 8:19 ` Jiri Kosina
2015-11-02 2:43 ` Rafael J. Wysocki
2015-11-02 10:45 ` Jiri Kosina
2015-11-02 11:00 ` Oliver Neukum
2015-11-02 15:18 ` Alan Stern
2015-11-03 0:10 ` Dave Chinner
2015-11-03 4:06 ` Rafael J. Wysocki
2015-11-03 9:31 ` Jan Kara
2015-11-03 21:33 ` Rafael J. Wysocki
2015-10-31 16:01 ` Alan Stern
2015-10-31 15:56 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201510302243.BOjZ7H2z%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jikos@kernel.org \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael.j.wysocki@intel.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).