From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753377AbbKBJEK (ORCPT ); Mon, 2 Nov 2015 04:04:10 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34247 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753262AbbKBJEF (ORCPT ); Mon, 2 Nov 2015 04:04:05 -0500 Date: Mon, 2 Nov 2015 09:03:59 +0000 From: Lee Jones To: Alexandre Belloni Cc: Krzysztof Kozlowski , Alim Akhtar , broonie@kernel.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC Message-ID: <20151102090359.GR4058@x1> References: <1446186334-16510-1-git-send-email-alim.akhtar@samsung.com> <1446186334-16510-5-git-send-email-alim.akhtar@samsung.com> <20151101174048.GD22331@piout.net> <5636A44D.4090908@samsung.com> <20151102004722.GI22331@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151102004722.GI22331@piout.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Nov 2015, Alexandre Belloni wrote: > On 02/11/2015 at 08:46:21 +0900, Krzysztof Kozlowski wrote : > > On 02.11.2015 02:40, Alexandre Belloni wrote: > > > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : > > >> RTC found in s2mps15 is almost same as one found on s2mps13 > > >> with few differences in RTC_UPDATE register fields, like: > > >> 1> Bit[4] and Bit[1] are reversed > > >> - On s2mps13 > > >> WUDR -> bit[4], AUDR -> bit[1] > > >> - On s2mps15 > > >> WUDR -> bit[1], AUDR -> bit[4] > > >> 2> In case of s2mps13, for alarm register, need to set both > > >> WDUR and ADUR high, whereas for s2mps15 only set AUDR to high. > > >> 3> On s2mps15, WUDR, RUDR and AUDR functions should never be used > > >> at the same time. > > >> > > >> This patch add required changes to enable s2mps15 rtc timer. > > >> > > >> Cc: Alexandre Belloni > > >> Signed-off-by: Alim Akhtar > > >> --- > > >> drivers/rtc/rtc-s5m.c | 37 +++++++++++++++++++++++++++++++++---- > > >> include/linux/mfd/samsung/rtc.h | 2 ++ > > >> 2 files changed, 35 insertions(+), 4 deletions(-) > > >> > > > Applied after fixing the small alignment issue, thanks. > > > > > > > I think you cannot apply it directly because it depends on headers from > > patch 2/4. It won't build. > > > > Yeah, this depends on the mfd tree. I don't thin Lee applied patch 2/4 > yet so I'm taking that one for 4.5. I don't mind if you take it, but if you do so you need to take the Regulator patch as well AND provide Mark and I a pull-request from an immutable branch please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog