From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753878AbbKBOtY (ORCPT ); Mon, 2 Nov 2015 09:49:24 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22351 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932074AbbKBOtT (ORCPT ); Mon, 2 Nov 2015 09:49:19 -0500 Date: Mon, 2 Nov 2015 17:48:38 +0300 From: Dan Carpenter To: "Simmons, James A." Cc: "'Greg Kroah-Hartman'" , James Simmons , "devel@driverdev.osuosl.org" , Oleg Drokin , Linux Kernel Mailing List , "lustre-devel@lists.lustre.org" Subject: Re: [lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c Message-ID: <20151102144837.GG18797@mwanda> References: <1446161303-798-1-git-send-email-jsimmons@infradead.org> <1446161303-798-2-git-send-email-jsimmons@infradead.org> <20151030230148.GB2920@kroah.com> <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <229dae23c2f34950a21db4bd6dbdcfba@EXCHCS32.ornl.gov> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yeah. That is often the fastest way to fix all the checkpatch warnings. Checkpatch warnings are pretty mechanical. Just send like 100 patches at a time until everything is fixed. Don't overthink. Say your patch breaks the alignment then you have to fix that, but otherwise only fix one thing at a time. Sometimes people will ask you to fix something else on the same line, but just say "I didn't introduce that, but yes I am planning to fix that in a later patchset since I am following the one thing per patch rule." Don't feel shame about sending many small patches. We pretty much merge everything. regards, dan carpenter