From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753936AbbKBQN6 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 11:13:58 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:48411 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751771AbbKBQN5 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 11:13:57 -0500
Date: Mon, 2 Nov 2015 17:13:51 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v3 1/2] cputime: fix invalid gtime in proc
Message-ID: <20151102161351.GT3604@twins.programming.kicks-ass.net>
References: <7F861DC0615E0C47A872E6F3C5FCDDBD05F575AA@BPXM14GP.gisp.nec.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD05F575AA@BPXM14GP.gisp.nec.co.jp>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 30, 2015 at 12:46:39AM +0000, Hiroshi Shimamoto wrote:
> +++ b/kernel/sched/cputime.c
> @@ -786,6 +786,9 @@ cputime_t task_gtime(struct task_struct *t)
>  	unsigned int seq;
>  	cputime_t gtime;
>  
> +	if (!context_tracking_is_enabled())
> +		return t->gtime;
> +

Yeah, not happy about that.. why do we have to touch context tracking
muck to find vtime state etc.

>  	do {
>  		seq = read_seqbegin(&t->vtime_seqlock);
>  
> -- 
> 1.8.3.1
>