From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754432AbbKBSNn (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Nov 2015 13:13:43 -0500
Received: from mail.savoirfairelinux.com ([208.88.110.44]:44558 "EHLO
	mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753024AbbKBSNk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Nov 2015 13:13:40 -0500
Date: Mon, 2 Nov 2015 13:13:34 -0500
From: Damien Riegel <damien.riegel@savoirfairelinux.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-watchdog@vger.kernel.org, shawnguo@kernel.org,
        kernel@pengutronix.de, wim@iguana.be, robh+dt@kernel.org,
        sameo@linux.intel.com, dinh.linux@gmail.com, linux@roeck-us.net,
        kernel@savoirfairelinux.com, arnd@arndb.de
Subject: Re: [PATCH v2 2/5] mfd: ts4800-syscon: add driver for TS-4800 syscon
Message-ID: <20151102181334.GA7200@localhost>
References: <1446150450-22093-1-git-send-email-damien.riegel@savoirfairelinux.com>
 <1446150450-22093-3-git-send-email-damien.riegel@savoirfairelinux.com>
 <20151030175656.GF4058@x1>
 <20151030200812.GB8666@localhost>
 <20151102091253.GS4058@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151102091253.GS4058@x1>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 02, 2015 at 09:12:53AM +0000, Lee Jones wrote:
> [Cc'ing Arnd]
> 
> On Fri, 30 Oct 2015, Damien Riegel wrote:
> > On Fri, Oct 30, 2015 at 05:56:56PM +0000, Lee Jones wrote:
> > > On Thu, 29 Oct 2015, Damien Riegel wrote:
> > > 
> > > > Driver for TS-4800 syscon. These registers belong to a FPGA that is
> > > > memory mapped and are used for counters, enable various IPs in the FPGA,
> > > > control LEDs, control IOs, etc.
> > > > 
> > > > Currently, only the watchdog is handled.
> > > 
> > > Why do you require your own syscon driver?
> > > 
> > > What's wrong with the generic one?
> > > 
> > 
> > The generic one uses a regmap_config with reg_stride set to 4 and val_bits
> > to 32.
> > 
> > TS-4800 syscon registers are 16-bit wide and must be accessed with 16
> > bit read and writes:
> > http://wiki.embeddedarm.com/wiki/TS-4800#Syscon
> > 
> > I will address the other issues in the next version (split commit,
> > license issue, style, and superfluous remove).
> 
> The Syscon driver was written to be generic so that each
> vendor/platform didn't require their own incarnation.  How unique is
> the TS-4800?
> 
> Perhaps it might be better to supply a generic 16 bit Syscon for
> devices akin to the TS-4800?

The TS-4800 syscon could use a generic 16-bit syscon. There is nothing
specific that requires a driver besides that.

We could add some optional properties to the generic syscon node to
configure reg_bits, val_bits, and reg_stride (and pad_bits ?). Would
that be a good solution ?

> Arnd, any opinion on this?
>