From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Liviu.Dudau@arm.com
Cc: Tomasz Nowicki <tn@semihalf.com>,
bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com,
catalin.marinas@arm.com, rjw@rjwysocki.net,
hanjun.guo@linaro.org, jiang.liu@linux.intel.com,
robert.richter@caviumnetworks.com,
Narinder.Dhillon@caviumnetworks.com, ddaney@caviumnetworks.com,
tglx@linutronix.de, wangyijing@huawei.com,
Suravee.Suthikulpanit@amd.com, msalter@redhat.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-acpi@lists.linaro.org
Subject: Re: [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init
Date: Tue, 3 Nov 2015 14:32:14 +0000 [thread overview]
Message-ID: <20151103143214.GD3574@red-moon> (raw)
In-Reply-To: <20151028114940.GL963@e106497-lin.cambridge.arm.com>
On Wed, Oct 28, 2015 at 11:49:40AM +0000, Liviu.Dudau@arm.com wrote:
> On Tue, Oct 27, 2015 at 05:38:42PM +0100, Tomasz Nowicki wrote:
[...]
> > +static int __init pcibios_assign_resources(void)
> > +{
> > + if (acpi_disabled)
> > + return 0;
> > +
> > + pci_assign_unassigned_resources();
> > + return 0;
>
> You can change this function into:
> {
> if (!acpi_disabled)
> pci_assign_unassigned_resources();
>
> return 0;
> }
>
> as the equivalent but shorter form.
I do not think it is a matter of code style here, it is a matter
of understanding when and if we want to reassign resources on ACPI
systems, it is an open question on ARM64 that must be sorted out (ie we
ignore FW/BARs set-up entirely).
> > +}
> > /*
> > - * raw_pci_read/write - Platform-specific PCI config space access.
> > + * rootfs_initcall comes after subsys_initcall and fs_initcall_sync,
> > + * so we know acpi scan and PCI_FIXUP_FINAL quirks have both run.
> > */
> > -int raw_pci_read(unsigned int domain, unsigned int bus,
> > - unsigned int devfn, int reg, int len, u32 *val)
>
> What happened with raw_pci_{read,write} ? Why do you remove them?
>
>
> > +rootfs_initcall(pcibios_assign_resources);
>
> Would you be so kind and explain to me why you need this initcall?
> Can you not set the PCI_REASSIGN_ALL_RSRC flag before calling
> pci_scan_root_bus() ?
On what basis ? BTW, PCI core code does not assign unassigned resources
anyway even if that flag is set, so some policy has to be defined here.
Thanks,
Lorenzo
> I haven't focused on ACPI before so I'm a bit hazy on the init order when
> that is enabled. That being said, I don't like adding in the architecture
> code initcall hooks just to fix up some dependency orders that could / should
> be fixed some other way.
>
> > +
> > +static void __iomem *
> > +pci_mcfg_dev_base(struct pci_bus *bus, unsigned int devfn, int offset)
> > {
> > - return -ENXIO;
> > + struct pci_mmcfg_region *cfg;
> > +
> > + cfg = pci_mmconfig_lookup(pci_domain_nr(bus), bus->number);
> > + if (cfg && cfg->virt)
> > + return cfg->virt +
> > + (PCI_MMCFG_BUS_OFFSET(bus->number) | (devfn << 12)) +
> > + offset;
> > + return NULL;
> > }
> >
> > -int raw_pci_write(unsigned int domain, unsigned int bus,
> > - unsigned int devfn, int reg, int len, u32 val)
> > +struct pci_ops pci_root_ops = {
> > + .map_bus = pci_mcfg_dev_base,
> > + .read = pci_generic_config_read,
> > + .write = pci_generic_config_write,
> > +};
> > +
> > +#ifdef CONFIG_PCI_MMCONFIG
> > +static int pci_add_mmconfig_region(struct acpi_pci_root_info *ci)
> > {
> > - return -ENXIO;
> > + struct pci_mmcfg_region *cfg;
> > + struct acpi_pci_root *root;
> > + int seg, start, end, err;
> > +
> > + root = ci->root;
> > + seg = root->segment;
> > + start = root->secondary.start;
> > + end = root->secondary.end;
> > +
> > + cfg = pci_mmconfig_lookup(seg, start);
> > + if (cfg)
> > + return 0;
> > +
> > + cfg = pci_mmconfig_alloc(seg, start, end, root->mcfg_addr);
> > + if (!cfg)
> > + return -ENOMEM;
> > +
> > + err = pci_mmconfig_inject(cfg);
> > + return err;
> > }
> >
> > -#ifdef CONFIG_ACPI
> > +static void pci_remove_mmconfig_region(struct acpi_pci_root_info *ci)
> > +{
> > + struct acpi_pci_root *root = ci->root;
> > + struct pci_mmcfg_region *cfg;
> > +
> > + cfg = pci_mmconfig_lookup(root->segment, root->secondary.start);
> > + if (cfg)
> > + return;
> > +
> > + if (cfg->hot_added)
> > + pci_mmconfig_delete(root->segment, root->secondary.start,
> > + root->secondary.end);
> > +}
> > +#else
> > +static int pci_add_mmconfig_region(struct acpi_pci_root_info *ci)
> > +{
> > + return 0;
> > +}
> > +
> > +static void pci_remove_mmconfig_region(struct acpi_pci_root_info *ci) { }
> > +#endif
> > +
> > +static int pci_acpi_root_init_info(struct acpi_pci_root_info *ci)
> > +{
> > + return pci_add_mmconfig_region(ci);
> > +}
> > +
> > +static void pci_acpi_root_release_info(struct acpi_pci_root_info *ci)
> > +{
> > + pci_remove_mmconfig_region(ci);
> > + kfree(ci);
> > +}
> > +
> > +static int pci_acpi_root_prepare_resources(struct acpi_pci_root_info *ci)
> > +{
> > + struct resource_entry *entry, *tmp;
> > + int ret;
> > +
> > + ret = acpi_pci_probe_root_resources(ci);
> > + if (ret < 0)
> > + return ret;
> > +
> > + resource_list_for_each_entry_safe(entry, tmp, &ci->resources) {
> > + struct resource *res = entry->res;
> > +
> > + /*
> > + * Special handling for ARM IO range
>
> There is nothing ARM specific here. It should apply to any memory mapped IO range.
>
> > + * TODO: need to move pci_register_io_range() function out
> > + * of drivers/of/address.c for both used by DT and ACPI
> > + */
> > + if (res->flags & IORESOURCE_IO) {
> > + unsigned long port;
> > + int err;
> > + resource_size_t length = res->end - res->start;
> > +
> > + err = pci_register_io_range(res->start, length);
> > + if (err) {
> > + resource_list_destroy_entry(entry);
> > + continue;
> > + }
> > +
> > + port = pci_address_to_pio(res->start);
> > + if (port == (unsigned long)-1) {
> > + resource_list_destroy_entry(entry);
> > + continue;
> > + }
> > +
> > + res->start = port;
> > + res->end = res->start + length - 1;
> > +
> > + if (pci_remap_iospace(res, res->start) < 0)
> > + resource_list_destroy_entry(entry);
> > + }
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static struct acpi_pci_root_ops acpi_pci_root_ops = {
> > + .pci_ops = &pci_root_ops,
> > + .init_info = pci_acpi_root_init_info,
> > + .release_info = pci_acpi_root_release_info,
> > + .prepare_resources = pci_acpi_root_prepare_resources,
> > +};
> > +
> > /* Root bridge scanning */
> > struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
> > {
> > - /* TODO: Should be revisited when implementing PCI on ACPI */
> > - return NULL;
> > + int node = acpi_get_node(root->device->handle);
> > + int domain = root->segment;
> > + int busnum = root->secondary.start;
> > + struct acpi_pci_root_info *info;
> > + struct pci_bus *bus;
> > +
> > + if (domain && !pci_domains_supported) {
> > + pr_warn("PCI %04x:%02x: multiple domains not supported.\n",
> > + domain, busnum);
> > + return NULL;
> > + }
> > +
> > + info = kzalloc_node(sizeof(*info), GFP_KERNEL, node);
> > + if (!info) {
> > + dev_err(&root->device->dev,
> > + "pci_bus %04x:%02x: ignored (out of memory)\n",
> > + domain, busnum);
> > + return NULL;
> > + }
> > +
> > + bus = acpi_pci_root_create(root, &acpi_pci_root_ops, info, root);
> > +
> > + /* After the PCI-E bus has been walked and all devices discovered,
> > + * configure any settings of the fabric that might be necessary.
> > + */
> > + if (bus) {
> > + struct pci_bus *child;
> > +
> > + list_for_each_entry(child, &bus->children, node)
> > + pcie_bus_configure_settings(child);
> > + }
> > +
> > + return bus;
> > }
> > #endif
> > --
> > 1.9.1
> >
>
> --
> ====================
> | I would like to |
> | fix the world, |
> | but they're not |
> | giving me the |
> \ source code! /
> ---------------
> ¯\_(ツ)_/¯
next prev parent reply other threads:[~2015-11-03 14:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 16:38 [PATCH V1 00/11] MMCONFIG refactoring and ARM64 PCI hostbridge init based on ACPI Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 01/11] x86, pci: Reorder logic of pci_mmconfig_insert() function Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 02/11] x86, pci, acpi: Move arch-agnostic MMCONFIG (aka ECAM) and ACPI code out of arch/x86/ directory Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 03/11] pci, acpi, mcfg: Provide generic implementation of MCFG code initialization Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 04/11] x86, pci: mmconfig_{32,64}.c code refactoring - remove code duplication Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 05/11] x86, pci, ecam: mmconfig_64.c becomes default implementation for ECAM driver Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 06/11] pci, acpi, mcfg: Provide default RAW ACPI PCI config space accessors Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 07/11] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y Tomasz Nowicki
2015-10-27 16:47 ` [Linaro-acpi] " Tomasz Nowicki
2015-10-27 17:25 ` Boris Ostrovsky
2015-10-28 10:49 ` Stefano Stabellini
2015-10-28 10:56 ` Tomasz Nowicki
2015-10-28 13:45 ` Hanjun Guo
2015-10-28 14:07 ` Boris Ostrovsky
2015-10-27 16:38 ` [PATCH V1 08/11] pci, acpi, ecam: Add flag to indicate whether ECAM region was hot added or not Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 09/11] x86, pci: Use previously added ECAM hot_added flag to remove ECAM regions Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 10/11] pci, acpi: Provide generic way to assign bus domain number Tomasz Nowicki
2015-10-28 11:38 ` Liviu.Dudau
2015-10-28 12:47 ` [Linaro-acpi] " Tomasz Nowicki
2015-11-03 16:10 ` Lorenzo Pieralisi
2015-11-04 10:04 ` [Linaro-acpi] " Tomasz Nowicki
2015-10-27 16:38 ` [PATCH V1 11/11] arm64, pci, acpi: Support for ACPI based PCI hostbridge init Tomasz Nowicki
2015-10-28 11:49 ` Liviu.Dudau
2015-10-28 13:42 ` Tomasz Nowicki
2015-10-28 13:51 ` Liviu.Dudau
2015-11-03 14:32 ` Lorenzo Pieralisi [this message]
2015-11-03 16:28 ` Liviu.Dudau
2015-10-28 18:46 ` Sinan Kaya
2015-11-03 14:15 ` Lorenzo Pieralisi
2015-11-03 14:39 ` Tomasz Nowicki
2015-11-03 15:10 ` Sinan Kaya
2015-11-03 15:59 ` Arnd Bergmann
2015-11-03 16:33 ` Sinan Kaya
2015-11-03 16:55 ` Arnd Bergmann
2015-11-03 17:43 ` Sinan Kaya
2015-11-05 14:48 ` [Linaro-acpi] " Sinan Kaya
2015-11-03 15:19 ` Hanjun Guo
2015-11-03 17:39 ` David Daney
2015-11-03 18:00 ` Gabriele Paoloni
2015-11-03 16:55 ` Lorenzo Pieralisi
2015-11-04 9:59 ` Tomasz Nowicki
2015-11-04 10:11 ` Tomasz Nowicki
2015-10-30 4:07 ` [PATCH V1 00/11] MMCONFIG refactoring and ARM64 PCI hostbridge init based on ACPI Jon Masters
2015-10-30 4:50 ` Hanjun Guo
2015-10-30 8:26 ` Tomasz Nowicki
2015-10-30 16:38 ` Suravee Suthikulpanit
2015-12-07 20:31 ` Bjorn Helgaas
[not found] ` <20151209100125.GA12632@jayachandranc.netlogicmicro.com>
2015-12-09 15:55 ` Lorenzo Pieralisi
[not found] ` <20151216125136.GE5890@jayachandranc.netlogicmicro.com>
2015-12-16 14:05 ` Lorenzo Pieralisi
2015-12-08 17:43 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103143214.GD3574@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Narinder.Dhillon@caviumnetworks.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=ddaney@caviumnetworks.com \
--cc=hanjun.guo@linaro.org \
--cc=jiang.liu@linux.intel.com \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robert.richter@caviumnetworks.com \
--cc=tglx@linutronix.de \
--cc=tn@semihalf.com \
--cc=wangyijing@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).