From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] regulator: tps65086: Add regulator driver for the TPS65086 PMIC
Date: Tue, 3 Nov 2015 16:31:17 +0000 [thread overview]
Message-ID: <20151103163117.GQ20228@sirena.org.uk> (raw)
In-Reply-To: <5638D97A.8040306@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
On Tue, Nov 03, 2015 at 09:57:46AM -0600, Andrew F. Davis wrote:
> On 10/31/2015 09:37 PM, Mark Brown wrote:
> >On Fri, Oct 30, 2015 at 05:41:43PM -0500, Andrew F. Davis wrote:
> >>+ struct regulator_desc desc;
> >>+ unsigned int decay_reg;
> >>+ unsigned int decay_mask;
> >The decay_reg and decay_mask fields appear to be entirely write only,
> >why are they present?
> Not sure what you mean, they are written to differently for each regulator,
> and read when setting the decay mode in _probe.
Ugh, that's a bit hidden (mostly due to not using the callback).
> >>+ ret = of_regulator_match(&pdev->dev, pdev->dev.of_node,
> >>+ tps65086_matches,
> >>+ ARRAY_SIZE(tps65086_matches));
> >>+ if (ret < 0) {
> >>+ dev_err(tps->dev, "Error parsing regulator init data\n");
> >>+ return ret;
> >>+ }
> >Please match regulators using the fields in the regulator_desc rather
> >than open coding.
> I need to match to get the driver specific information for each regulator,
> if I let regulator_register do it I never get a chance to process the match,
> unless there is a callback or something I'm missing.
There's a callback you are missing, of_parse_cb().
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-03 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 22:41 [PATCH v2 0/6] Add support for the TI TPS65086 PMIC Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 1/6] Documentation: tps65086: Add DT bindings for the " Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 2/6] Documentation: tps65086: Add DT bindings for the TPS65086 regulators Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 3/6] Documentation: tps65086: Add DT bindings for the TPS65086 GPO controller Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 4/6] mfd: tps65086: Add driver for the TPS65086 PMIC Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 5/6] regulator: tps65086: Add regulator " Andrew F. Davis
2015-11-01 2:37 ` Mark Brown
2015-11-03 15:57 ` Andrew F. Davis
2015-11-03 16:31 ` Mark Brown [this message]
2015-11-03 17:57 ` Andrew F. Davis
2015-10-30 22:41 ` [PATCH v2 6/6] gpio: tps65086: Add GPIO " Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103163117.GQ20228@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).