From: Michael Welling <mwelling@ieee.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh@kernel.org>, kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Tony Lindgren <tony@atomide.com>,
Pavel Machek <pavel@ucw.cz>, Felipe Balbi <balbi@ti.com>,
Sebastian Reichel <sre@kernel.org>, Roger Quadros <rogerq@ti.com>,
Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings
Date: Tue, 3 Nov 2015 17:11:56 -0600 [thread overview]
Message-ID: <20151103231156.GA10138@deathstar> (raw)
In-Reply-To: <20151103225913.GA29032@dtor-ws>
On Tue, Nov 03, 2015 at 02:59:13PM -0800, Dmitry Torokhov wrote:
> On Tue, Nov 03, 2015 at 09:41:17AM -0600, Michael Welling wrote:
> > On Tue, Nov 03, 2015 at 09:31:10AM -0600, Rob Herring wrote:
> > > On Tue, Nov 3, 2015 at 1:21 AM, Dmitry Torokhov
> > > <dmitry.torokhov@gmail.com> wrote:
> > > > On Mon, Nov 02, 2015 at 02:50:29PM -0600, Michael Welling wrote:
> > > >> On Mon, Nov 02, 2015 at 09:19:50AM -0600, Rob Herring wrote:
> > > >> > > +Required properties:
> > > >> > > + - compatible : "ti,tsc2004"
> > > >> > > + - interrupts : IRQ specifier
> > > >> > > + - vio-supply : Regulator specifier
> > > >> >
> > > >> > reg property?
> > > >>
> > > >> Rob,
> > > >>
> > > >> It appears that I missed this in the description.
> > > >>
> > > >> Probably because I was following the lead of the ts2005 description.
> > > >>
> > > >> How does this look:
> > > >> - reg : I2C address. 0x48 - 0x4b based on the voltage applied to
> > > >> the AD1 and AD0 inputs on the IC.
> > > >>
> > > >
> > > > How about the version below?
> > > >
> > > > Thanks.
> > > >
> > > > --
> > > > Dmitry
> > > >
> > > >
> > > > Input: tsc2004 - document ts2004 dt bindings
> >
> > Just noticed that it says ts2004 instead of tsc2004 in the subject.
> > Otherwise, I am fine with it.
> >
> > Thanks for the assistance.
> >
> > Still no acks or reviews for the other patches in the series.
> > I would like for someone to test the tsc2005 support to see if it still works.
> >
> > The tsc2004 works very well on the target that I have here.
>
> I folded this patch into the patch #3 and applied everything.
>
Great.
Will this patch series conflict with the patch series to take out the .owner=THIS_MODULE
from spi_drivers?
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1004626.html
> Thanks!
>
> --
> Dmitry
next prev parent reply other threads:[~2015-11-03 23:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-31 0:41 [PATCH v4 0/4] tsc2005 - Add support for tsc2004 Michael Welling
2015-10-31 0:41 ` [PATCH 1/4] Input: tsc2005 - Separate SPI and core functions Michael Welling
2015-11-03 1:49 ` Dmitry Torokhov
2015-11-03 15:48 ` Michael Welling
2015-10-31 0:41 ` [PATCH 2/4] Input: tsc200x-core - Rename functions and variables Michael Welling
2015-10-31 0:41 ` [PATCH 3/4] Input: tsc2004 - Add support for tsc2004 Michael Welling
2015-10-31 0:41 ` [PATCH 4/4] Input: tsc2004 - Document ts2004 dt bindings Michael Welling
2015-11-02 15:19 ` Rob Herring
2015-11-02 20:50 ` Michael Welling
2015-11-03 7:21 ` Dmitry Torokhov
2015-11-03 15:31 ` Rob Herring
2015-11-03 15:41 ` Michael Welling
2015-11-03 22:59 ` Dmitry Torokhov
2015-11-03 23:11 ` Michael Welling [this message]
2015-11-03 23:30 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151103231156.GA10138@deathstar \
--to=mwelling@ieee.org \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).