From: Jeff Layton <jlayton@poochiereds.net>
To: Tejun Heo <tj@kernel.org>
Cc: Chris Worley <chris.worley@primarydata.com>,
linux-kernel@vger.kernel.org, bfields@fieldses.org,
Michael Skralivetsky <michael.skralivetsky@primarydata.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Shaohua Li <shli@fb.com>
Subject: Re: timer code oops when calling mod_delayed_work
Date: Wed, 4 Nov 2015 06:48:36 -0500 [thread overview]
Message-ID: <20151104064836.661b0e01@tlielax.poochiereds.net> (raw)
In-Reply-To: <20151104000658.GH5749@mtj.duckdns.org>
On Tue, 3 Nov 2015 19:06:58 -0500
Tejun Heo <tj@kernel.org> wrote:
> Hello, Jeff.
>
> Can you please verify whether the following patch fixes the issue?
>
> Thanks.
>
> diff --git a/kernel/time/timer.c b/kernel/time/timer.c
> index 84190f0..566a282 100644
> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -970,12 +970,21 @@ EXPORT_SYMBOL(add_timer);
> */
> void add_timer_on(struct timer_list *timer, int cpu)
> {
> - struct tvec_base *base = per_cpu_ptr(&tvec_bases, cpu);
> + struct tvec_base *new_base = per_cpu_ptr(&tvec_bases, cpu);
> + struct tvec_base *base;
> unsigned long flags;
>
> timer_stats_timer_set_start_info(timer);
> BUG_ON(timer_pending(timer) || !timer->function);
> - spin_lock_irqsave(&base->lock, flags);
> +
> + base = lock_timer_base(timer, &flags);
> + if (base != new_base) {
> + timer->flags |= TIMER_MIGRATING;
> + spin_unlock(&base->lock);
> + base = new_base;
> + spin_lock(&base->lock);
> + }
> +
> timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu;
> debug_activate(timer, timer->expires);
> internal_add_timer(base, timer);
Yes, thanks! That fixes my reproducer and Chris also said he was unable
to reproduce the bug after applying that patch. You can add this if you
like:
Tested-by: Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2015-11-04 11:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 14:31 timer code oops when calling mod_delayed_work Jeff Layton
2015-10-29 17:58 ` Jeff Layton
2015-10-31 2:00 ` Tejun Heo
2015-10-31 11:34 ` Jeff Layton
2015-10-31 21:31 ` Tejun Heo
2015-10-31 21:54 ` Jeff Layton
2015-11-02 19:48 ` Chris Worley
2015-11-02 19:56 ` Jeff Layton
2015-11-03 1:33 ` Jeff Layton
2015-11-03 17:55 ` Jeff Layton
2015-11-03 22:54 ` Tejun Heo
2015-11-04 0:06 ` Tejun Heo
2015-11-04 11:48 ` Jeff Layton [this message]
2015-11-04 17:15 ` [PATCH] timer: add_timer_on() should perform proper migration Tejun Heo
2015-11-04 19:27 ` [tip:timers/urgent] timers: Use proper base migration in add_timer_on() tip-bot for Tejun Heo
2015-11-04 19:35 ` [PATCH] timer: add_timer_on() should perform proper migration Thomas Gleixner
2015-11-04 19:43 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104064836.661b0e01@tlielax.poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=bfields@fieldses.org \
--cc=chris.worley@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.skralivetsky@primarydata.com \
--cc=shli@fb.com \
--cc=tj@kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).