linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, acme@kernel.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing
Date: Wed, 4 Nov 2015 09:42:48 +0100	[thread overview]
Message-ID: <20151104084248.GF29671@krava.brq.redhat.com> (raw)
In-Reply-To: <1446515428-7450-4-git-send-email-andi@firstfloor.org>

On Mon, Nov 02, 2015 at 05:50:22PM -0800, Andi Kleen wrote:

SNIP

>  		evsel->attr.type == PERF_TYPE_HW_CACHE &&
>  		evsel->attr.config ==  ( PERF_COUNT_HW_CACHE_L1D |
>  					((PERF_COUNT_HW_CACHE_OP_READ) << 8) |
> -					((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16)) &&
> -			runtime_l1_dcache_stats[ctx][cpu].n != 0) {
> -		print_l1_dcache_misses(out, cpu, evsel, avg);
> +					 ((PERF_COUNT_HW_CACHE_RESULT_MISS) << 16))) {
> +		if (runtime_l1_dcache_stats[ctx][cpu].n != 0)
> +			print_l1_dcache_misses(cpu, evsel, avg, out);
> +		else
> +			print_metric(ctxp, NULL, NULL, "of all L1-dcache hits", 0);

hum, what's the reason for all those else cases
ending up printing nothing?

we have one metric per line anyway right?

jirka

  parent reply	other threads:[~2015-11-04  8:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  1:50 perf, tools: Refactor and support interval and CSV metrics v6 Andi Kleen
2015-11-03  1:50 ` [PATCH 1/9] perf, tools, stat: Move sw clock metrics printout to stat-shadow Andi Kleen
2015-11-04  8:15   ` Jiri Olsa
2015-11-08  7:28   ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2015-11-03  1:50 ` [PATCH 2/9] tools, perf, stat: Use common printout faction to avoid duplicated code Andi Kleen
2015-11-04  8:15   ` Jiri Olsa
2015-11-08  7:28   ` [tip:perf/urgent] perf stat: Use common printout function " tip-bot for Andi Kleen
2015-11-03  1:50 ` [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-11-04  8:34   ` Jiri Olsa
2015-11-04  8:42   ` Jiri Olsa [this message]
2015-11-05  2:43     ` Andi Kleen
2015-11-05  6:52       ` Jiri Olsa
2015-11-05 15:20         ` Andi Kleen
2015-11-03  1:50 ` [PATCH 4/9] perf, tools, stat: Add support for metrics in interval mode Andi Kleen
2015-11-03  1:50 ` [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout Andi Kleen
2015-11-04  8:48   ` Jiri Olsa
2015-11-03  1:50 ` [PATCH 6/9] perf, tools, stat: Implement CSV metrics output Andi Kleen
2015-11-03  1:50 ` [PATCH 7/9] perf, tools, stat: Move non counting counter printing to printout Andi Kleen
2015-11-03  1:50 ` [PATCH 8/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen
2015-11-03  1:50 ` [PATCH 9/9] perf, tools, stat: Document CSV format in manpage Andi Kleen
2015-11-03  7:46 ` perf, tools: Refactor and support interval and CSV metrics v6 Jiri Olsa
2015-11-05  2:43   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2015-10-23 23:59 perf, tools: Refactor and support interval and CSV metrics v5 Andi Kleen
2015-10-23 23:59 ` [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen
2015-09-21 23:49 perf, tools: Refactor and support interval and CSV metrics v4 Andi Kleen
2015-09-21 23:49 ` [PATCH 3/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151104084248.GF29671@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).