From: Mark Brown <broonie@kernel.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Michal Suchanek <hramrach@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support
Date: Wed, 4 Nov 2015 14:41:12 +0000 [thread overview]
Message-ID: <20151104144112.GJ1717@sirena.org.uk> (raw)
In-Reply-To: <1446545174-14193-3-git-send-email-vigneshr@ti.com>
[-- Attachment #1: Type: text/plain, Size: 521 bytes --]
On Tue, Nov 03, 2015 at 03:36:11PM +0530, Vignesh R wrote:
> + ti_qspi_enable_memory_map(spi);
> + ti_qspi_setup_mmap_read(spi, read_opcode, addr_width,
> + dummy_bytes);
> + memcpy_fromio(buf, qspi->mmap_base + from, len);
> + *retlen = len;
> + ti_qspi_disable_memory_map(spi);
We'll be constantly enabling and disabling memory mapping with this.
I'm not sure that's a meaningful cost given that it doesn't actually
remap anything but rather just switches hardware modes, we can always
optimise it later if it is.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-11-04 14:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 10:06 [PATCH v2 0/5] Add memory mapped read support for ti-qspi Vignesh R
2015-11-03 10:06 ` [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices Vignesh R
2015-11-03 11:19 ` Michal Suchanek
2015-11-04 4:48 ` Vignesh R
2015-11-04 14:39 ` Mark Brown
2015-11-05 12:29 ` Vignesh R
2015-11-05 15:29 ` Mark Brown
2015-11-03 10:06 ` [PATCH v2 2/5] spi: spi-ti-qspi: add mmap mode read support Vignesh R
2015-11-04 14:41 ` Mark Brown [this message]
2015-11-05 6:16 ` Vignesh R
2015-11-03 10:06 ` [PATCH v2 3/5] mtd: devices: m25p80: add support for mmap read request Vignesh R
2015-11-03 10:06 ` [PATCH v2 4/5] ARM: dts: DRA7: add entry for qspi mmap region Vignesh R
2015-11-05 16:36 ` Rob Herring
2015-11-03 10:06 ` [PATCH v2 5/5] ARM: dts: AM4372: " Vignesh R
2015-11-05 23:51 ` Rob Herring
2015-11-06 5:14 ` Felipe Balbi
2015-11-06 12:21 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104144112.GJ1717@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).