From: Stephen Boyd <sboyd@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
robh+dt@kernel.org, lee.jones@linaro.org,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
mark.rutland@arm.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org, nm@ti.com,
devicetree@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH 1/3] PM / OPP: Add "opp-supported-hw" binding
Date: Wed, 4 Nov 2015 14:08:14 -0800 [thread overview]
Message-ID: <20151104220814.GS19782@codeaurora.org> (raw)
In-Reply-To: <20151103022933.GN3639@ubuntu>
On 11/03, Viresh Kumar wrote:
> On 30-10-15, 15:18, Stephen Boyd wrote:
> > A side-note. I wonder if it would be better style to have the
> > node name be:
> >
> > opp@600000000 {
> >
> > At least it seems that the assumption is we can store all the
> > possible combinations of OPP values for a particular frequency in
> > the same node. Following this style would make dt compilation
> > fail if two nodes have the same frequency.
>
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Date: Tue, 3 Nov 2015 07:51:09 +0530
> Subject: [PATCH] PM / OPP: Rename OPP nodes as opp@<opp-hz>
>
> It would be better to name OPP nodes as opp@<opp-hz> as that will ensure
> that multiple DT nodes don't contain the same frequency. Of course we
> expect the writer to name the node with its opp-hz frequency and not any
> other frequency.
>
> And that will let the compile error out if multiple nodes are using the
> same opp-hz frequency.
>
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-04 22:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1446167359.git.viresh.kumar@linaro.org>
2015-10-30 1:25 ` [PATCH 1/3] PM / OPP: Add "opp-supported-hw" binding Viresh Kumar
2015-10-30 21:49 ` Stephen Boyd
2015-10-31 2:16 ` Viresh Kumar
2015-11-02 19:21 ` Stephen Boyd
2015-11-03 2:12 ` Viresh Kumar
2015-11-04 22:10 ` Stephen Boyd
2015-11-02 16:07 ` Viresh Kumar
2015-10-30 22:18 ` Stephen Boyd
2015-10-31 2:20 ` Viresh Kumar
2015-11-02 15:13 ` Rob Herring
2015-11-02 16:08 ` Viresh Kumar
2015-11-02 19:20 ` Stephen Boyd
2015-11-03 2:29 ` Viresh Kumar
2015-11-04 22:08 ` Stephen Boyd [this message]
2015-10-30 1:25 ` [PATCH 2/3] PM / OPP: Add {opp-microvolt|opp-microamp|turbo-mode|opp-suspend}-<name> binding Viresh Kumar
2015-10-30 21:54 ` Stephen Boyd
2015-10-30 1:25 ` [PATCH 3/3] PM / OPP: Remove 'operating-points-names' binding Viresh Kumar
2015-10-30 21:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151104220814.GS19782@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).