From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756305AbbKEFaT (ORCPT ); Thu, 5 Nov 2015 00:30:19 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:60456 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbbKEFaR (ORCPT ); Thu, 5 Nov 2015 00:30:17 -0500 Date: Thu, 05 Nov 2015 00:30:15 -0500 (EST) Message-Id: <20151105.003015.45063597738858813.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: stmmac: remove unneeded phy_iface variable From: David Miller In-Reply-To: <1446667692-6182-1-git-send-email-clabbe.montjoie@gmail.com> References: <1446667692-6182-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Nov 2015 21:30:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: LABBE Corentin Date: Wed, 4 Nov 2015 21:08:12 +0100 > The variable phy_iface is double-initialized and finally is not necessary > at all. > > Reported-by: coverity (CID 1271141) > Signed-off-by: LABBE Corentin The value is used in two locations, so having it computed once in a variable is useful. Please just eliminate the double assignment.