From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
robh+dt@kernel.org, sboyd@codeaurora.org, lee.jones@linaro.org,
linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
mark.rutland@arm.com, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org, nm@ti.com,
devicetree@vger.kernel.org, b.zolnierkie@samsung.com,
m.szyprowski@samsung.com,
open list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH V2 2/5] PM / OPP: Add {opp-microvolt|opp-microamp|turbo-mode|opp-suspend}-<name> binding
Date: Thu, 5 Nov 2015 08:49:13 +0530 [thread overview]
Message-ID: <20151105031913.GA29491@ubuntu> (raw)
In-Reply-To: <20151105030245.GA20613@rob-hp-laptop>
On 04-11-15, 21:02, Rob Herring wrote:
> > +- turbo-mode-<name>: Named turbo-mode property. Similar to opp-microvolt-<name>
> > + property, but for turbo mode instead.
> > +
> > - opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in
> > the table should have this.
> >
> > +- opp-suspend-<name>: Named opp-suspend property. Similar to
> > + opp-microvolt-<name> property, but for suspend opp instead.
> > +
>
> I don't think these last 2 make sense. turbo-mode is a flag that the
> mode has restrictions such as other cores have to be idle or something.
> Similarly, opp-suspend should not vary by <name>.
Based on what version of the hardware you are running, via
opp-supported-hw property, the platform can enable a different set of
OPPs. And in that case we may want to select different OPPs marked as
turbo or suspend freq. That's what I thought at least.
For example, on version A of the hardware we have following available
frequencies: 800, 1000, 1100, 1200 MHz. Where 800 MHz is the suspend
freq and 1200 is the turbo one.
But on a slightly different version of hardware B, we have two more
OPPs available: 700 and 1400 MHz. And in that case we want the suspend
freq to be 700 and turbo OPP to be only 1400 MHz.
--
viresh
next prev parent reply other threads:[~2015-11-05 3:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1446687367.git.viresh.kumar@linaro.org>
2015-11-05 1:41 ` [PATCH V2 1/5] PM / OPP: Add "opp-supported-hw" binding Viresh Kumar
2015-11-05 2:57 ` Rob Herring
2015-11-05 1:41 ` [PATCH V2 2/5] PM / OPP: Add {opp-microvolt|opp-microamp|turbo-mode|opp-suspend}-<name> binding Viresh Kumar
2015-11-05 3:02 ` Rob Herring
2015-11-05 3:19 ` Viresh Kumar [this message]
2015-11-05 23:33 ` Rob Herring
2015-11-06 1:53 ` Viresh Kumar
2015-11-10 14:55 ` Viresh Kumar
2015-11-10 15:37 ` Rob Herring
2015-11-05 1:41 ` [PATCH V2 3/5] PM / OPP: Remove 'operating-points-names' binding Viresh Kumar
2015-11-05 3:09 ` Rob Herring
2015-11-05 1:41 ` [PATCH V2 4/5] PM / OPP: Rename OPP nodes as opp@<opp-hz> Viresh Kumar
2015-11-05 3:18 ` Rob Herring
2015-11-05 1:41 ` [PATCH V2 5/5] ARM: dts: exynos4412: " Viresh Kumar
2015-11-05 1:51 ` Krzysztof Kozlowski
2015-11-05 1:57 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105031913.GA29491@ubuntu \
--to=viresh.kumar@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=pawel.moll@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).