From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>
Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, wangnan0@huawei.com,
namhyung@kernel.org, ast@kernel.org,
masami.hiramatsu.pt@hitachi.com, kan.liang@intel.com,
adrian.hunter@intel.com, jolsa@kernel.org, dsahern@gmail.com
Subject: Re: [PATCH] perf tools: Change FEATURE-DUMP to FEATURE-DUMP.libbpf for lib bpf
Date: Thu, 5 Nov 2015 10:23:52 -0300 [thread overview]
Message-ID: <20151105132352.GO13236@kernel.org> (raw)
In-Reply-To: <1446706594-4142-1-git-send-email-yunlong.song@huawei.com>
Em Thu, Nov 05, 2015 at 02:56:34PM +0800, Yunlong Song escreveu:
> Commit ed63f34c026e9a60d17fa750ecdfe3f600d49393 ("perf tools: Make perf
> depend on libbpf") dynamically creates FEATURE-DUMP.libbpf during the
> perf building, but the .gitignore under tools/lib/bpf/ mistakes
> FEATURE-DUMP.libbpf for FEATURE-DUMP. Besides, the Makefile under
> tools/lib/bpf/ also mistakes FEATURE-DUMP.libbpf for FEATURE-DUMP, which
> causes that "make clean" will leave (or say create) FEATURE-DUMP.libbpf
> rather than remove FEATURE-DUMP.libbpf file.
Ok, so the cset that created files with a .libbpf suffix was this one:
commit 65f041bee783
Author: Arnaldo Carvalho de Melo <acme@redhat.com>
Date: Mon Sep 21 17:25:27 2015 -0300
tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf
-------
That has this tag:
Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")
---
The cset you mention, ed63f34c026e9a60d17fa750ecdfe3f600d49393, just
makes perf call the code introduced by 1b76c13e4b36 and fixed by
65f041bee783, i.e. you start noticing, when building perf, that those
files are created.
Anyway, fixing it up, thanks for the patch!
- Arnaldo
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> tools/lib/bpf/.gitignore | 2 +-
> tools/lib/bpf/Makefile | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/bpf/.gitignore b/tools/lib/bpf/.gitignore
> index 812aeed..f81e549 100644
> --- a/tools/lib/bpf/.gitignore
> +++ b/tools/lib/bpf/.gitignore
> @@ -1,2 +1,2 @@
> libbpf_version.h
> -FEATURE-DUMP
> +FEATURE-DUMP.libbpf
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index fc9af57..a3caaf3 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -180,7 +180,7 @@ config-clean:
> clean:
> $(call QUIET_CLEAN, libbpf) $(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d \
> $(RM) LIBBPF-CFLAGS
> - $(call QUIET_CLEAN, core-gen) $(RM) $(OUTPUT)FEATURE-DUMP
> + $(call QUIET_CLEAN, core-gen) $(RM) $(OUTPUT)FEATURE-DUMP.libbpf
>
>
>
> --
> 1.8.5.2
next prev parent reply other threads:[~2015-11-05 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 6:56 [PATCH] perf tools: Change FEATURE-DUMP to FEATURE-DUMP.libbpf for lib bpf Yunlong Song
2015-11-05 13:23 ` Arnaldo Carvalho de Melo [this message]
2015-11-06 2:08 ` Yunlong Song
2015-11-08 7:30 ` [tip:perf/urgent] tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf tip-bot for Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151105132352.GO13236@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.hunter@intel.com \
--cc=ast@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=wangnan0@huawei.com \
--cc=yunlong.song@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).