linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-next: manual merge of the ftrace tree with Linus' tree
Date: Thu, 5 Nov 2015 13:51:40 +1100	[thread overview]
Message-ID: <20151105135140.2399976f@canb.auug.org.au> (raw)

Hi Steven,

Today's linux-next merge of the ftrace tree got a conflict in:

  kernel/trace/trace_stack.c

between commit:

  a2d762904832 ("tracing: Have stack tracer force RCU to be watching")

from Linus' tree and commit:

  d332736df0c2 ("tracing: Rename max_stack_lock to stack_trace_max_lock")

from the ftrace tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc kernel/trace/trace_stack.c
index 8abf1ba18085,0bd212af406c..000000000000
--- a/kernel/trace/trace_stack.c
+++ b/kernel/trace/trace_stack.c
@@@ -85,19 -91,9 +91,19 @@@ check_stack(unsigned long ip, unsigned 
  	if (!object_is_on_stack(stack))
  		return;
  
 +	/* Can't do this from NMI context (can cause deadlocks) */
 +	if (in_nmi())
 +		return;
 +
  	local_irq_save(flags);
- 	arch_spin_lock(&max_stack_lock);
+ 	arch_spin_lock(&stack_trace_max_lock);
  
 +	/*
 +	 * RCU may not be watching, make it see us.
 +	 * The stack trace code uses rcu_sched.
 +	 */
 +	rcu_irq_enter();
 +
  	/* In case another CPU set the tracer_frame on us */
  	if (unlikely(!frame_size))
  		this_size -= tracer_frame;
@@@ -179,8 -175,7 +185,8 @@@
  	}
  
   out:
 +	rcu_irq_exit();
- 	arch_spin_unlock(&max_stack_lock);
+ 	arch_spin_unlock(&stack_trace_max_lock);
  	local_irq_restore(flags);
  }
  

             reply	other threads:[~2015-11-05  2:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05  2:51 Stephen Rothwell [this message]
2015-11-05  3:20 ` linux-next: manual merge of the ftrace tree with Linus' tree Steven Rostedt
  -- strict thread matches above, loose matches on Subject: below --
2023-08-28  1:59 Stephen Rothwell
2023-04-11  2:46 Stephen Rothwell
2023-04-11  3:01 ` Steven Rostedt
2021-10-28  5:31 Stephen Rothwell
2021-10-28 13:14 ` Steven Rostedt
2021-09-15  0:44 Stephen Rothwell
2021-09-15  0:47 ` Steven Rostedt
2021-02-15  4:03 Stephen Rothwell
2020-12-08  5:02 Stephen Rothwell
2020-12-14 20:37 ` Stephen Rothwell
2020-12-14 21:33   ` Steven Rostedt
2019-05-16  1:05 Stephen Rothwell
2019-05-16  1:53 ` Steven Rostedt
2019-05-16  3:32   ` Stephen Rothwell
2019-05-16  1:00 Stephen Rothwell
2018-08-15  4:04 Stephen Rothwell
2013-07-10  3:51 Stephen Rothwell
2013-04-22  5:55 Stephen Rothwell
2013-04-09  6:30 Stephen Rothwell
2013-03-18  2:00 Stephen Rothwell
2013-03-18 13:26 ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151105135140.2399976f@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).