From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758138AbbKGEdP (ORCPT ); Fri, 6 Nov 2015 23:33:15 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:53399 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbbKGEdN (ORCPT ); Fri, 6 Nov 2015 23:33:13 -0500 Date: Fri, 06 Nov 2015 23:33:11 -0500 (EST) Message-Id: <20151106.233311.2260896695923603885.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: lars.persson@axis.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" From: David Miller In-Reply-To: <563C5392.6030309@users.sourceforge.net> References: <5317A59D.4@users.sourceforge.net> <563C5392.6030309@users.sourceforge.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 06 Nov 2015 20:33:13 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SF Markus Elfring Date: Fri, 6 Nov 2015 08:15:30 +0100 > From: Markus Elfring > Date: Fri, 6 Nov 2015 08:00:22 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Please resubmit this with a more appropriate Subject line. The subsystem prefix should be all lower-case and typically indicate the most specific subsystem or area being changed. In this case it's a driver, therefore simply use the driver name "dwc_eth_qos: ".