From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm9713: add gpio chip
Date: Fri, 6 Nov 2015 09:48:28 +0000 [thread overview]
Message-ID: <20151106094828.GD3378@x1> (raw)
In-Reply-To: <20151106092733.GG2549@ck-lbox>
On Fri, 06 Nov 2015, Charles Keepax wrote:
> On Fri, Nov 06, 2015 at 09:29:13AM +0000, Lee Jones wrote:
> > On Wed, 04 Nov 2015, Robert Jarzmik wrote:
> >
> > > Charles Keepax <ckeepax@opensource.wolfsonmicro.com> writes:
> > >
> > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote:
> > > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the
> > > >> kernel, declare a gpio chip.
> > > >>
> > > >> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> > > >> ---
> > > >
> > > > You should probably make a seperate driver within GPIO for this
> > > > and then tie the two together, using an MFD. I appreciate that is
> > > > more work but it is likely a nicer solution overall.
> > >
> > > I'd like to first have a confirmation from :
> > > - Mark (Brown)
> > > - and Lee (Jones)
> > >
> > > The confirmation I'm looking for states that :
> > > - the wm9713 should have a part in the mfd tree
> > > - the gpio part should be in drivers/gpio
> > > - the sound soc codecs will remain as is
> > > - if the future driver/mfd/wm9713.c is technically sound, it will be accepted
> > >
> > > I remember at least one example where the MFD approach was rejected from mfd
> > > tree for pxa gpios, so I won't work unless I have a confirmation from both
> > > maintainers.
> >
> > I have no idea what you're talking about. Context please?
>
> Apologies Lee, we are discussing a patch that adds a GPIO driver
> into an AC97 CODEC. I had suggested that perhaps we should put
> the GPIO driver as a seperate driver under GPIO and link the two
> with an MFD. But Mark has already replied in the thread to say
> that he doesn't think that will be necessary. Although he did
> raise some concerns that perhaps it could be done more generally
> as it should apply to other AC97 CODECs as well.
>
> So I think you can probably safely ignore this for now, sorry
> for the noise.
Roger that. Thanks for the explanation.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-11-06 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 17:12 [PATCH] ASoC: wm9713: add gpio chip Robert Jarzmik
2015-11-04 18:33 ` Charles Keepax
2015-11-04 19:35 ` Robert Jarzmik
2015-11-05 9:48 ` Charles Keepax
2015-11-06 9:29 ` Lee Jones
2015-11-06 9:27 ` Charles Keepax
2015-11-06 9:48 ` Lee Jones [this message]
2015-11-06 20:47 ` Robert Jarzmik
2015-11-06 21:22 ` Mark Brown
2015-11-05 10:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106094828.GD3378@x1 \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).