From: Will Deacon <will.deacon@arm.com>
To: Yang Shi <yang.shi@linaro.org>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option
Date: Fri, 6 Nov 2015 12:30:09 +0000 [thread overview]
Message-ID: <20151106123008.GK6087@arm.com> (raw)
In-Reply-To: <1446658671-16238-1-git-send-email-yang.shi@linaro.org>
On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote:
> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
> it in arch/arm64/Kconfig.debug.
It might be worth noting that this adds a dependency on DEBUG_KERNEL
for building with frame pointers. I'm ok with that (it appears to be
enabled in defconfig and follows the vast majority of other archs) but
it is a change in behaviour.
With that:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---
> arch/arm64/Kconfig.debug | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug
> index d6285ef..915dea7 100644
> --- a/arch/arm64/Kconfig.debug
> +++ b/arch/arm64/Kconfig.debug
> @@ -2,10 +2,6 @@ menu "Kernel hacking"
>
> source "lib/Kconfig.debug"
>
> -config FRAME_POINTER
> - bool
> - default y
> -
> config ARM64_PTDUMP
> bool "Export kernel pagetable layout to userspace via debugfs"
> depends on DEBUG_KERNEL
> --
> 2.0.2
>
next prev parent reply other threads:[~2015-11-06 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 17:37 [PATCH] arm64: remove redundant FRAME_POINTER kconfig option Yang Shi
2015-11-06 12:30 ` Will Deacon [this message]
2015-11-06 12:50 ` Mark Rutland
2015-11-06 15:42 ` Will Deacon
2015-11-06 16:21 ` Catalin Marinas
2015-11-06 16:25 ` Will Deacon
2015-11-06 17:23 ` Shi, Yang
2015-11-06 17:35 ` Catalin Marinas
2015-11-06 17:39 ` Shi, Yang
2015-11-06 17:51 ` Catalin Marinas
2015-11-06 17:55 ` Shi, Yang
2015-11-09 15:58 ` Catalin Marinas
2015-11-06 16:12 ` Catalin Marinas
2015-11-06 16:19 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151106123008.GK6087@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.shi@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).