linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: punit vara <punitvara@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error
Date: Sat, 7 Nov 2015 01:16:24 +0300	[thread overview]
Message-ID: <20151106221624.GE18797@mwanda> (raw)
In-Reply-To: <CABXAfNJZSgy+2v1VH8LVhYTtjsgKGmY3u7eyu8mUfYMezRcFPQ@mail.gmail.com>

Oh...  Sorry.  I got your email confused with someone else.

> > diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> > index 2a5b36f..0805050 100644
> > --- a/drivers/staging/wilc1000/linux_wlan.c
> > +++ b/drivers/staging/wilc1000/linux_wlan.c
> > @@ -1780,6 +1780,7 @@ int wilc_netdev_init(struct wilc **wilc)
> >  /*The 1st function called after module inserted*/
> >  static int __init init_wilc_driver(void)
> >  {
> > +       struct wilc *wilc;
> >  #ifdef WILC_SPI
> >         struct wilc *wilc;
> >  #endif


The problem is that now if WILC_SPI is defined it's declared twice so
this patch is definitely wrong.  I haven't looked at it further than
that, sorry.

CC the atmel people with these patches.  Use ./scripts/get_maintainer.pl
to find the right maintainers.

regards,
dan carpenter


  reply	other threads:[~2015-11-06 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06 21:59 [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error Punit Vara
2015-11-06 22:06 ` Dan Carpenter
2015-11-06 22:09 ` punit vara
2015-11-06 22:16   ` Dan Carpenter [this message]
2015-11-06 22:17   ` punit vara
2015-11-06 22:21     ` punit vara
2015-11-06 22:42 ` kbuild test robot
2015-11-07  0:57 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151106221624.GE18797@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=punitvara@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).