From: Peter Zijlstra <peterz@infradead.org>
To: Arseniy Krasnov <a.krasnov@samsung.com>
Cc: linux@arm.linux.org.uk, mingo@redhat.com, v.tyrtov@samsung.com,
s.rogachev@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] High performance balancing logic for big.LITTLE
Date: Sat, 7 Nov 2015 10:52:37 +0100 [thread overview]
Message-ID: <20151107095237.GS3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1446811367-23783-1-git-send-email-a.krasnov@samsung.com>
No, no, no, no.
This is horrible and exactly what I've been telling people I do not want
to see.
This is very arch specific scheduler code, and very badly done. It
doesn't even call the groups big and little, it goes so far as to put a7
and a15 in sched domain member names.
It doesn't get topology information from device tree but from hard coded
CONFIG strings.
It introduces a swap_task function while we already have one.
It doesn't integrate with any of the other bits that make up and
influence energy consumption such as cpuidle and cpufreq (very minor one
way).
It doesn't mention the existing energy-aware-scheduling effort, nor how
that approach cannot be made to work for this.
It has a completely broken SoB chain.
It introduces new metrics (like druntime) without first defining them;
and in general very poor Changelogs.
In general, this makes me very sad. Please start by participating in the
existing discussion.
prev parent reply other threads:[~2015-11-07 9:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 12:02 [PATCH 00/13] High performance balancing logic for big.LITTLE Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 01/13] hperf_hmp: add new config for arm and arm64 Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 02/13] hperf_hmp: introduce hew domain flag Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 03/13] hperf_hmp: add sched domains initialization Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 04/13] hperf_hmp: scheduler initialization routines Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 05/13] hperf_hmp: introduce druntime metric Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 06/13] hperf_hmp: is_hmp_imbalance introduced Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 07/13] hperf_hmp: migration auxiliary functions Arseniy Krasnov
2015-11-06 13:03 ` kbuild test robot
2015-11-06 12:02 ` [PATCH 08/13] hperf_hmp: swap tasks function Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 09/13] hperf_hmp: one way balancing function Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 10/13] hperf_hmp: idle pull function Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 11/13] hperf_hmp: task CPU selection logic Arseniy Krasnov
2015-11-06 12:29 ` kbuild test robot
2015-11-06 12:02 ` [PATCH 12/13] hperf_hmp: rest of logic Arseniy Krasnov
2015-11-06 12:02 ` [PATCH 13/13] hperf_hmp: cpufreq routines Arseniy Krasnov
2015-11-07 9:52 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151107095237.GS3604@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=a.krasnov@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=s.rogachev@samsung.com \
--cc=v.tyrtov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).