From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752323AbbKJK0D (ORCPT ); Tue, 10 Nov 2015 05:26:03 -0500 Received: from mx0a-001ae601.pphosted.com ([67.231.149.25]:43972 "EHLO mx0a-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbbKJK0A (ORCPT ); Tue, 10 Nov 2015 05:26:00 -0500 Date: Tue, 10 Nov 2015 10:10:04 +0000 From: Charles Keepax To: Peter Robinson CC: Lee Jones , , , Mark Brown , Subject: Re: [PATCH] mfd: wm8994: Add module description/author/license information Message-ID: <20151110101004.GH2549@ck-lbox> References: <1446913539-8940-1-git-send-email-pbrobinson@gmail.com> <1446913539-8940-2-git-send-email-pbrobinson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1446913539-8940-2-git-send-email-pbrobinson@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-11-10_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1511100178 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 07, 2015 at 04:25:39PM +0000, Peter Robinson wrote: > When compiled as a module we get a tainted kernel because of the lack > of the module information and the following errors. Add details to > fix the issue when wm8994_irq/wm8994_regmap are modular. > > wm8994_irq: module license 'unspecified' taints kernel. > > wm8994_irq: Unknown symbol irq_domain_xlate_twocell (err 0) > wm8994_irq: Unknown symbol regmap_write (err 0) > wm8994_irq: Unknown symbol gpiod_to_irq (err 0) > wm8994_irq: Unknown symbol irq_modify_status (err 0) > wm8994_irq: Unknown symbol irq_set_chip_and_handler_name (err 0) > wm8994_irq: Unknown symbol regmap_add_irq_chip (err 0) > wm8994_irq: Unknown symbol gpiod_get_raw_value_cansleep (err 0) > wm8994_irq: Unknown symbol handle_nested_irq (err 0) > wm8994_irq: Unknown symbol __irq_domain_add (err 0) > wm8994_irq: Unknown symbol irq_create_mapping (err 0) > wm8994_irq: Unknown symbol gpio_to_desc (err 0) > wm8994_irq: Unknown symbol regmap_del_irq_chip (err 0) > wm8994_regmap: module license 'unspecified' taints kernel. > > Cc: > Signed-off-by: Peter Robinson > --- This looks like the intention was for 8994 to be a single module can you try the following and see if that also fixes your issue. Thanks, Charles >>From ba8cea5e6193c501070553f2f78d1ac59aae252d Mon Sep 17 00:00:00 2001 From: Charles Keepax Date: Tue, 10 Nov 2015 10:06:29 +0000 Subject: [PATCH] mfd: wm8994: Ensure that the whole MFD is built into a single module Signed-off-by: Charles Keepax --- drivers/mfd/Makefile | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index ef09bf1..b9c229d 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -63,7 +63,8 @@ wm8350-objs := wm8350-core.o wm8350-regmap.o wm8350-gpio.o wm8350-objs += wm8350-irq.o obj-$(CONFIG_MFD_WM8350) += wm8350.o obj-$(CONFIG_MFD_WM8350_I2C) += wm8350-i2c.o -obj-$(CONFIG_MFD_WM8994) += wm8994-core.o wm8994-irq.o wm8994-regmap.o +wm8994-objs := wm8994-core.o wm8994-irq.o wm8994-regmap.o +obj-$(CONFIG_MFD_WM8994) += wm8994.o obj-$(CONFIG_TPS6105X) += tps6105x.o obj-$(CONFIG_TPS65010) += tps65010.o -- 1.7.2.5