From: Petr Mladek <pmladek@suse.com>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: live-patching@vger.kernel.org, jpoimboe@redhat.com,
sjenning@redhat.com, jikos@kernel.org, vojtech@suse.com,
jeyu@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc
Date: Wed, 18 Nov 2015 17:55:14 +0100 [thread overview]
Message-ID: <20151118165514.GO4431@pathway.suse.cz> (raw)
In-Reply-To: <564CA9BC.8020903@canonical.com>
On Wed 2015-11-18 10:39:24, Chris J Arges wrote:
> On 11/18/2015 10:37 AM, Petr Mladek wrote:
> > On Mon 2015-11-16 11:03:06, Chris J Arges wrote:
> >> In cases of duplicate symbols, sympos will be used to disambiguate instead
> >> of val. By default sympos will be 0, and patching will only succeed if
> >> the symbol is unique. Specifying a positive value will ensure that
> >> occurrence of the symbol in kallsyms for the patched object will be used
> >> for patching if it is valid.
> >>
> >> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol
> >> as they are no longer used.
> >>
> >> >From the klp_reloc structure remove val, as it can be refactored as a
> > ^
> > Please, remove this extra '>'. I guess that you cut&pasted the
> > comment from a mail reply ;-)
> >
> > Best Regards,
> > Petr
> >
>
> I think that '>' was added in a subsequent reply. My patch doesn't have
> that, and I'm guessing checkpatch would have warned me about that as well.
> : )
Heh, it seems that some mail delivery tool or mail client tries to be
clever. I see the '>' in you original mail. But it is fine in the
archive, see
http://article.gmane.org/gmane.linux.kernel/2086364
http://marc.info/?l=linux-kernel&m=144769343212421
I am sorry for the noise.
Best Regards,
Petr
next prev parent reply other threads:[~2015-11-18 16:55 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 17:58 [PATCH] livepatch: old_name.number scheme in livepatch sysfs directory Chris J Arges
2015-11-02 19:15 ` Jessica Yu
2015-11-02 19:52 ` [PATCH] " Josh Poimboeuf
2015-11-02 20:16 ` Chris J Arges
2015-11-02 20:32 ` Josh Poimboeuf
2015-11-02 22:59 ` [PATCH v2] " Chris J Arges
2015-11-03 9:50 ` Miroslav Benes
2015-11-03 15:03 ` Josh Poimboeuf
2015-11-03 10:52 ` Miroslav Benes
2015-11-03 12:44 ` Petr Mladek
2015-11-03 15:03 ` Josh Poimboeuf
2015-11-03 19:57 ` Jiri Kosina
2015-11-03 20:06 ` Josh Poimboeuf
[not found] ` <1447259366-7055-1-git-send-email-chris.j.arges@canonical.com>
2015-11-11 16:28 ` [PATCH 1/3 v4] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-11-11 17:43 ` Josh Poimboeuf
2015-11-12 10:22 ` Miroslav Benes
2015-11-11 16:29 ` [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc Chris J Arges
2015-11-11 16:39 ` Chris J Arges
2015-11-11 17:57 ` Josh Poimboeuf
2015-11-12 14:31 ` Petr Mladek
2015-11-12 19:19 ` Josh Poimboeuf
2015-11-13 13:54 ` Petr Mladek
2015-11-13 16:59 ` Josh Poimboeuf
2015-11-16 12:11 ` Petr Mladek
2015-11-12 10:23 ` Miroslav Benes
2015-11-11 16:29 ` [PATCH 3/3 v4] livepatch: old_name,number scheme in livepatch sysfs directory Chris J Arges
2015-11-11 18:01 ` Josh Poimboeuf
[not found] ` <1447347595-30728-1-git-send-email-chris.j.arges@canonical.com>
2015-11-12 16:59 ` [PATCH 1/4 v5] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-11-12 19:45 ` Josh Poimboeuf
2015-11-13 9:56 ` Jiri Kosina
2015-11-13 10:14 ` Miroslav Benes
2015-11-13 16:27 ` Petr Mladek
2015-11-12 16:59 ` [PATCH 2/4 v5] livepatch: Simplify code for relocated external symbols Chris J Arges
2015-11-13 10:24 ` Miroslav Benes
2015-11-13 13:55 ` Petr Mladek
2015-11-12 16:59 ` [PATCH 3/4 v5] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges
2015-11-12 19:50 ` Josh Poimboeuf
2015-11-13 16:42 ` Petr Mladek
2015-11-12 16:59 ` [PATCH 4/4 v5] livepatch: function,sympos scheme in livepatch sysfs directory Chris J Arges
[not found] ` <1447431804-18786-1-git-send-email-chris.j.arges@canonical.com>
2015-11-13 16:23 ` [PATCH 1/3 v6] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-11-13 16:23 ` [PATCH 2/3 v6] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges
2015-11-13 16:23 ` [PATCH 3/3 v6] livepatch: function,sympos scheme in livepatch sysfs directory Chris J Arges
[not found] ` <1447693391-10065-1-git-send-email-chris.j.arges@canonical.com>
2015-11-16 17:03 ` [PATCH 1/3 v7] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-11-16 21:59 ` Jiri Kosina
2015-11-17 14:29 ` Chris J Arges
2015-11-19 10:02 ` Jiri Kosina
2015-11-16 17:03 ` [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges
2015-11-18 9:56 ` Miroslav Benes
2015-11-18 14:01 ` Josh Poimboeuf
2015-11-18 16:47 ` Petr Mladek
2015-11-18 16:37 ` Petr Mladek
2015-11-18 16:39 ` Chris J Arges
2015-11-18 16:55 ` Petr Mladek [this message]
2015-11-18 20:34 ` Jiri Kosina
2015-11-16 17:03 ` [PATCH 3/3 v7] livepatch: function,sympos scheme in livepatch sysfs directory Chris J Arges
2015-11-20 17:25 ` [PATCH 0/3 v8] livepatch: disambiguate symbols with the same name Chris J Arges
2015-11-20 17:25 ` [PATCH 1/3 v8] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-11-23 9:47 ` Miroslav Benes
2015-11-20 17:25 ` [PATCH 2/3 v8] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges
2015-11-23 9:52 ` Miroslav Benes
2015-11-30 20:46 ` Chris J Arges
2015-12-01 1:17 ` Josh Poimboeuf
2015-11-20 17:25 ` [PATCH 3/3 v8] livepatch: function,sympos scheme in livepatch sysfs directory Chris J Arges
2015-11-23 9:47 ` Miroslav Benes
2015-12-02 2:40 ` [PATCH 0/3 v9] livepatch: disambiguate symbols with the same name Chris J Arges
2015-12-02 2:40 ` [PATCH 1/3 v9] livepatch: add old_sympos as disambiguator field to klp_func Chris J Arges
2015-12-02 2:40 ` [PATCH 2/3 v9] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges
2015-12-14 12:45 ` Miroslav Benes
2015-12-02 2:40 ` [PATCH 3/3 v9] livepatch: function,sympos scheme in livepatch sysfs directory Chris J Arges
2015-12-02 15:28 ` [PATCH 0/3 v9] livepatch: disambiguate symbols with the same name Petr Mladek
2015-12-03 17:59 ` Josh Poimboeuf
2015-12-03 22:04 ` Jiri Kosina
2015-11-03 14:58 ` [PATCH v2] livepatch: old_name.number scheme in livepatch sysfs directory Josh Poimboeuf
2015-11-03 16:09 ` Miroslav Benes
2015-11-03 16:50 ` Josh Poimboeuf
2015-11-03 20:42 ` Chris J Arges
2015-11-04 9:52 ` Miroslav Benes
2015-11-04 16:03 ` Josh Poimboeuf
2015-11-04 16:17 ` Chris J Arges
2015-11-05 15:18 ` Miroslav Benes
2015-11-05 15:56 ` Josh Poimboeuf
2015-11-05 16:07 ` Chris J Arges
2015-11-09 16:16 ` [PATCH v3] livepatch: old_name,number " Chris J Arges
2015-11-09 20:56 ` Josh Poimboeuf
2015-11-09 23:01 ` Chris J Arges
2015-11-10 4:54 ` Josh Poimboeuf
2015-11-10 8:49 ` Miroslav Benes
2015-11-10 13:40 ` Josh Poimboeuf
2015-11-10 9:02 ` Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151118165514.GO4431@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=chris.j.arges@canonical.com \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).