From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753281AbbKWFhg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 Nov 2015 00:37:36 -0500
Received: from mail.kernel.org ([198.145.29.136]:50888 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751173AbbKWFhe (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 Nov 2015 00:37:34 -0500
Date: Mon, 23 Nov 2015 13:37:05 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>
Subject: Re: [PATCH 11/19] ARM: dts: imx: replace legacy *,wakeup property
 with wakeup-source
Message-ID: <20151123053705.GH13744@tiger>
References: <1445422216-29375-1-git-send-email-sudeep.holla@arm.com>
 <1445422216-29375-12-git-send-email-sudeep.holla@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445422216-29375-12-git-send-email-sudeep.holla@arm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 21, 2015 at 11:10:08AM +0100, Sudeep Holla wrote:
> Though the keyboard and other driver will continue to support the legacy
> "gpio-key,wakeup", "linux,wakeup" boolean property to enable the wakeup
> source, "wakeup-source" is the new standard binding.
> 
> This patch replaces all the legacy wakeup properties with the unified
> "wakeup-source" property in order to avoid any futher copy-paste
> duplication.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

<snip>

> diff --git a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> index 321662f53e33..16fc69c69ab2 100644
> --- a/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> +++ b/arch/arm/boot/dts/imx51-digi-connectcore-som.dtsi
> @@ -156,7 +156,7 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_esdhc2>;
>  	cap-sdio-irq;
> -	enable-sdio-wakeup;
> +	wakeup-source;

I do not see this be mentioned in commit log.  I do not see relevant
kernel changes in v4.4-rc1 to support that.  Am I missing anything? 

Shawn

>  	keep-power-in-suspend;
>  	max-frequency = <50000000>;
>  	no-1-8-v;