On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote: > + /* The mute state as set by alsa using the digital_mute callback */ > + bool alsa_mute_state; > + /* The mute state as set by the userspace mute control */ > + bool control_mute_state; > + /* The actual mute state is equal to an OR of the above */ Does the device *need* the digital mute to avoid noise? If there's no strong need for it then just don't bother which simplifies the code a lot. Otherwise this looks good.