From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbbK3WxZ (ORCPT ); Mon, 30 Nov 2015 17:53:25 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:32990 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbbK3WxW (ORCPT ); Mon, 30 Nov 2015 17:53:22 -0500 Date: Mon, 30 Nov 2015 17:53:18 -0500 From: Tejun Heo To: "Serge E. Hallyn" Cc: serge@hallyn.com, linux-kernel@vger.kernel.org, adityakali@google.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, lxc-devel@lists.linuxcontainers.org, akpm@linux-foundation.org, ebiederm@xmission.com Subject: Re: [PATCH 1/8] kernfs: Add API to generate relative kernfs path Message-ID: <20151130225318.GD9039@mtj.duckdns.org> References: <1447703505-29672-1-git-send-email-serge@hallyn.com> <1447703505-29672-2-git-send-email-serge@hallyn.com> <20151124161630.GL17033@mtj.duckdns.org> <20151127052511.GA25490@mail.hallyn.com> <20151130151147.GG3535@mtj.duckdns.org> <20151130183758.GA25433@mail.hallyn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151130183758.GA25433@mail.hallyn.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Serge. On Mon, Nov 30, 2015 at 12:37:58PM -0600, Serge E. Hallyn wrote: > > Yeah, I agree but the name is kinda misleading tho. The output isn't > > really a relative path but rather absolute path against the specified > > root. Maybe updating the function and parameter names would be > > helpful? > > > > Ok - updating the comment is simple enough. Though the name/params > kernfs_path_from_node_locked(from, to) still seem to make sense. Would > you prefer something like kernfs_absolute_path_from node_locked()? I > hesitate to call 'from' 'root' since kernfs_root is a thing and this > is not that. Hmmm... I see. Let's just make sure that the comment is clear about the fact that it calculates (pseudo) absolute path rather than relative path. Thanks. -- tejun