From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbbLATau (ORCPT ); Tue, 1 Dec 2015 14:30:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:56168 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbbLATat (ORCPT ); Tue, 1 Dec 2015 14:30:49 -0500 Date: Tue, 01 Dec 2015 14:30:47 -0500 (EST) Message-Id: <20151201.143047.82022857078130793.davem@davemloft.net> To: sunil.kovvuri@gmail.com Cc: eric.dumazet@gmail.com, p.fedin@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sunil.Goutham@caviumnetworks.com, sgoutham@cavium.com Subject: Re: [PATCH 3/6] net: thunderx: Increase transmit queue length From: David Miller In-Reply-To: References: <01d101d12c46$2de43b40$89acb1c0$@samsung.com> <1448983985.25582.35.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Dec 2015 11:30:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sunil Kovvuri Date: Tue, 1 Dec 2015 22:00:49 +0530 > Increasing descriptor ring size will lead to more memory allocation. > And what you are seeing is a memory alloc failure and doesn't seem > to be due to this driver change. I mean it looks like the behavior > will be same for other drivers as well. The driver should successfully recover from out of memory situations and not stop RX/TX completely. There might be some other problem with your driver causing this. Don't put this off as not "related" to your patch, it is as this introduces the behavior for this user, and you should fix it before expecting me to apply this patch series.