From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756609AbbLAO4F (ORCPT ); Tue, 1 Dec 2015 09:56:05 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:52091 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756540AbbLAO4C (ORCPT ); Tue, 1 Dec 2015 09:56:02 -0500 Date: Tue, 1 Dec 2015 15:55:57 +0100 From: Peter Zijlstra To: Andi Kleen Cc: Andi Kleen , linux-kernel@vger.kernel.org, mingo@kernel.org Subject: Re: [PATCH 2/2] x86, perf: Use INST_RETIRED.PREC_DIST for cycles:ppp Message-ID: <20151201145557.GO3816@twins.programming.kicks-ass.net> References: <1448929689-13771-1-git-send-email-andi@firstfloor.org> <1448929689-13771-2-git-send-email-andi@firstfloor.org> <20151201134151.GN3816@twins.programming.kicks-ass.net> <20151201145414.GE3528@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151201145414.GE3528@tassilo.jf.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 01, 2015 at 06:54:14AM -0800, Andi Kleen wrote: > On Tue, Dec 01, 2015 at 02:41:51PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 30, 2015 at 04:28:09PM -0800, Andi Kleen wrote: > > > diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c > > > index 9dfbba5..ba41899 100644 > > > --- a/arch/x86/kernel/cpu/perf_event.c > > > +++ b/arch/x86/kernel/cpu/perf_event.c > > > @@ -482,6 +482,9 @@ int x86_pmu_hw_config(struct perf_event *event) > > > /* Support for IP fixup */ > > > if (x86_pmu.lbr_nr || x86_pmu.intel_cap.pebs_format >= 2) > > > precise++; > > > + > > > + if (x86_pmu.pebs_aliases) > > > + precise++; > > > > This is not accurate, it would allow :ppp for core2 for example, which > > does not at all support PREC_DIST events. > > > > Something like so on top? > > Yes that's fine. Thanks. > > Are you just applying it with that change, or should I resend a combined patch? Yep, got it in. Thanks.