From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757325AbbLBAqb (ORCPT ); Tue, 1 Dec 2015 19:46:31 -0500 Received: from muru.com ([72.249.23.125]:49971 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756575AbbLBAq3 (ORCPT ); Tue, 1 Dec 2015 19:46:29 -0500 Date: Tue, 1 Dec 2015 16:46:24 -0800 From: Tony Lindgren To: Matthijs van Duin Cc: lkml , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Brian Hutchinson , Delio Brignoli , Neil Armstrong , Philipp Rosenberger Subject: Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask Message-ID: <20151202004623.GX23396@atomide.com> References: <1449013103-23238-1-git-send-email-tony@atomide.com> <1449013103-23238-11-git-send-email-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matthijs van Duin [151201 16:26]: > On 2 December 2015 at 00:38, Tony Lindgren wrote: > > - pinctrl-single,function-mask = <0x300ff>; > > + pinctrl-single,function-mask = <0x707ff>; > > Reminder that silicon revision 2.1 and older require input enabled > (bit 18 set) for all 3.3V I/Os to avoid cumulative hardware damage. > (Errata advisory 2.1.87) Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3 dts macros that ensure that? Regards, Tony