From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932571AbbLBOPi (ORCPT ); Wed, 2 Dec 2015 09:15:38 -0500 Received: from smtprelay0130.hostedemail.com ([216.40.44.130]:54319 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932104AbbLBOPg (ORCPT ); Wed, 2 Dec 2015 09:15:36 -0500 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3622:3865:3866:3870:3872:3874:5007:6119:6261:7875:7903:9012:10004:10400:10450:10455:10848:10967:11026:11232:11658:11914:12438:12517:12519:12740:13069:13311:13357:14659:19904:19999:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:5,LUA_SUMMARY:none X-HE-Tag: week84_6ad9abf2da52a X-Filterd-Recvd-Size: 1561 Date: Wed, 2 Dec 2015 09:15:33 -0500 From: Steven Rostedt To: Jiri Olsa Cc: LKML , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH] ftrace: Remove use of control list and ops Message-ID: <20151202091533.1eea65cf@gandalf.local.home> In-Reply-To: <20151202075911.GA26308@krava.brq.redhat.com> References: <20151130173640.2c45b429@gandalf.local.home> <20151201134213.GA14155@krava.brq.redhat.com> <20151201095554.7b56bff7@gandalf.local.home> <20151201155744.GA24786@krava.local> <20151201115655.1b7e79e6@gandalf.local.home> <20151202075911.GA26308@krava.brq.redhat.com> X-Mailer: Claws Mail 3.13.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2015 08:59:11 +0100 Jiri Olsa wrote: > > - op->func(ip, parent_ip, op, regs); > > + preempt_disable_notrace(); > > I was wondering about not disabling preemption in the original > ftrace_ops_recurs_func function.. thats why I added new one ;-) Yeah, I paused on that too. But then I realized that pretty much all callers of function tracing disable preemption too, so it shouldn't cause really any more overhead. -- Steve