linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ftrace: Remove use of control list and ops
Date: Wed, 2 Dec 2015 15:50:32 +0100	[thread overview]
Message-ID: <20151202145032.GA5255@krava.brq.redhat.com> (raw)
In-Reply-To: <20151202092700.7021eda8@gandalf.local.home>

On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote:
> On Wed, 2 Dec 2015 09:58:26 +0100
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote:
> > 
> > SNIP
> > 
> > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long parent_ip,
> > > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
> > >  				   struct ftrace_ops *op, struct pt_regs *regs)
> > >  {
> > >  	int bit;
> > >  
> > > +	if ((op->flags & FTRACE_OPS_FL_RCU) && !rcu_is_watching())
> > > +		return;
> > > +
> > >  	bit = trace_test_and_set_recursion(TRACE_LIST_START, TRACE_LIST_MAX);
> > >  	if (bit < 0)
> > >  		return;
> > >  
> > > -	op->func(ip, parent_ip, op, regs);
> > > +	preempt_disable_notrace();
> > >  
> > > +	if (!(op->flags & FTRACE_OPS_FL_PER_CPU) ||
> > > +	    ftrace_function_local_disabled(op)) {  
> > 
> > should be !ftrace_function_local_disabled(op) in here,
> > I passed my test with attached patch
> > 
> 
> Can you retest with this patch:

sure, but other than the declaration removal it's the same change

jirka

  reply	other threads:[~2015-12-02 14:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 22:36 [PATCH] ftrace: Remove use of control list and ops Steven Rostedt
2015-12-01 13:42 ` Jiri Olsa
2015-12-01 14:55   ` Steven Rostedt
2015-12-01 15:57     ` Jiri Olsa
2015-12-01 16:56       ` Steven Rostedt
2015-12-02  7:59         ` Jiri Olsa
2015-12-02 14:15           ` Steven Rostedt
2015-12-02  8:58         ` Jiri Olsa
2015-12-02 14:27           ` Steven Rostedt
2015-12-02 14:50             ` Jiri Olsa [this message]
2015-12-02 15:03               ` Steven Rostedt
2015-12-02 15:23                 ` Jiri Olsa
2015-12-18 10:18                   ` Jiri Olsa
2015-12-18 14:35                     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151202145032.GA5255@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).