From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932377AbbLBPXy (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Dec 2015 10:23:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34836 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752494AbbLBPXx (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Dec 2015 10:23:53 -0500
Date: Wed, 2 Dec 2015 16:23:50 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] ftrace: Remove use of control list and ops
Message-ID: <20151202152350.GA11342@krava.brq.redhat.com>
References: <20151130173640.2c45b429@gandalf.local.home>
 <20151201134213.GA14155@krava.brq.redhat.com>
 <20151201095554.7b56bff7@gandalf.local.home>
 <20151201155744.GA24786@krava.local>
 <20151201115655.1b7e79e6@gandalf.local.home>
 <20151202085826.GA1068@krava.brq.redhat.com>
 <20151202092700.7021eda8@gandalf.local.home>
 <20151202145032.GA5255@krava.brq.redhat.com>
 <20151202100346.3fa57158@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151202100346.3fa57158@gandalf.local.home>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 02, 2015 at 10:03:46AM -0500, Steven Rostedt wrote:
> On Wed, 2 Dec 2015 15:50:32 +0100
> Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Wed, Dec 02, 2015 at 09:27:00AM -0500, Steven Rostedt wrote:
> > > On Wed, 2 Dec 2015 09:58:26 +0100
> > > Jiri Olsa <jolsa@redhat.com> wrote:
> > >   
> > > > On Tue, Dec 01, 2015 at 11:56:55AM -0500, Steven Rostedt wrote:
> > > > 
> > > > SNIP
> > > >   
> > > > > -static void ftrace_ops_recurs_func(unsigned long ip, unsigned long parent_ip,
> > > > > +static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
> > > > >  				   struct ftrace_ops *op, struct pt_regs *regs)
> > > > >  {
> > > > >  	int bit;
> > > > >  
> > > > > +	if ((op->flags & FTRACE_OPS_FL_RCU) && !rcu_is_watching())
> > > > > +		return;
> > > > > +
> > > > >  	bit = trace_test_and_set_recursion(TRACE_LIST_START, TRACE_LIST_MAX);
> > > > >  	if (bit < 0)
> > > > >  		return;
> > > > >  
> > > > > -	op->func(ip, parent_ip, op, regs);
> > > > > +	preempt_disable_notrace();
> > > > >  
> > > > > +	if (!(op->flags & FTRACE_OPS_FL_PER_CPU) ||
> > > > > +	    ftrace_function_local_disabled(op)) {    
> > > > 
> > > > should be !ftrace_function_local_disabled(op) in here,
> > > > I passed my test with attached patch
> > > >   
> > > 
> > > Can you retest with this patch:  
> > 
> > sure, but other than the declaration removal it's the same change
> > 
> 
> Yep, but I'm paranoid :-) Any change I like to get retested. But if
> you're fine, can I get a 'Tested-by' from you?

yep, I re-tested ;-)

Tested-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka