From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbbLBUVc (ORCPT ); Wed, 2 Dec 2015 15:21:32 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:33510 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750772AbbLBUVa (ORCPT ); Wed, 2 Dec 2015 15:21:30 -0500 Date: Wed, 2 Dec 2015 12:21:27 -0800 From: Brian Norris To: Simon Arlott Cc: Florian Fainelli , Rob Herring , "devicetree@vger.kernel.org" , Linux Kernel Mailing List , David Woodhouse , linux-mtd@lists.infradead.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonas Gorski , bcm-kernel-feedback-list@broadcom.com, Kamal Dasu , Boris Brezillon Subject: Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding Message-ID: <20151202202127.GN64635@google.com> References: <56523E85.905@simon.arlott.org.uk> <56523EFF.9050502@simon.arlott.org.uk> <56535977.9050201@gmail.com> <56541BD3.4070202@simon.arlott.org.uk> <5654AF69.7040901@gmail.com> <20151202190555.GJ64635@google.com> <565F4953.2070206@simon.arlott.org.uk> <20151202200036.GL64635@google.com> <565F50B0.4020802@simon.arlott.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <565F50B0.4020802@simon.arlott.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon, On Wed, Dec 02, 2015 at 08:12:32PM +0000, Simon Arlott wrote: > On 02/12/15 20:00, Brian Norris wrote: > > On Wed, Dec 02, 2015 at 07:41:07PM +0000, Simon Arlott wrote: > >> I've created a bcm963268part driver so there won't need to be any > >> partitions in DT for bcm63268. > > > > Just curious, do you plan to submit this driver? We're working on > > Yes, it's just the most recent one I've been working on. I still have > USBH and IUDMA to submit > > > matching up partition parsers to flash devices via device tree > > of_match_table's, so you could do something like this: > > > > nand0: nandcs@0 { > > compatible = "brcm,nandcs"; > > ... > > > > partitions { > > compatible = "brcm,bcm963268-partitions"; > > ... > > }; > > }; > > I modified brcmnand to look for a machine matching "brcm,bcm963268", but Like this? http://patchwork.ozlabs.org/patch/473180/ I'd like to avoid that (hence the "Rejected" status). > that way is ok with me. Presumably "ofpart" defers to another matching > partition parser? Yes, "ofpart" is for specifying the entire partition table in the device tree as subnodes of either the flash node or of the flash's "partitions" subnode. It's not the most flexible, but it does work generically. > Is there a patch for that method of parser detection available? I have something working here, but I haven't had time to finish cleaning it up and submitting it. There's an older patch that works similarly, though it has some deficiencies: http://patchwork.ozlabs.org/patch/475988/ The main difference between that and my (yet-to-be-submitted) proposal is that I'd like parsers to opt in by adding a proper of_match_table with non-Linux-specific DT bindings, and then we can drop the "linux,..." naming and make it a reasonably generic property. Regards, Brian