From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760519AbbLCOtO (ORCPT ); Thu, 3 Dec 2015 09:49:14 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36308 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212AbbLCOtM (ORCPT ); Thu, 3 Dec 2015 09:49:12 -0500 Date: Thu, 3 Dec 2015 09:49:09 -0500 From: Tejun Heo To: Ulrich Obergfell , Ingo Molnar , Peter Zijlstra , Andrew Morton Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] workqueue: implement lockup detector Message-ID: <20151203144909.GB27463@mtj.duckdns.org> References: <20151203002810.GJ19878@mtj.duckdns.org> <20151203002839.GK19878@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151203002839.GK19878@mtj.duckdns.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 02, 2015 at 07:28:39PM -0500, Tejun Heo wrote: ... > +void touch_workqueue_watchdog(int cpu) > +{ > + /* > + * If not explicitly touched, these stamps are never updated, which > + * means that they may affect stall detection if jiffies wraps; > + * however, it's highly unlikely and the worst that can happen is > + * delaying stall detection by upto one threshold duration. > + */ Oops, this comment is stale. Updated the code but forgot to drop it. Will remove in the next iteration. Thanks. -- tejun