From: Petr Mladek <pmladek@suse.com>
To: Torsten Duwe <duwe@lst.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Jiri Kosina <jkosina@suse.cz>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
live-patching@vger.kernel.org
Subject: Re: [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables
Date: Thu, 3 Dec 2015 17:20:08 +0100 [thread overview]
Message-ID: <20151203162008.GF8047@pathway.suse.cz> (raw)
In-Reply-To: <20151125172916.9D50269260@newverein.lst.de>
On Wed 2015-11-25 17:37:33, Torsten Duwe wrote:
> * Makefile:
> - globally use -mprofile-kernel in case it's configured.
> * arch/powerpc/Kconfig / kernel/trace/Kconfig:
> - declare that ppc64le HAVE_MPROFILE_KERNEL and
> HAVE_DYNAMIC_FTRACE_WITH_REGS, and use it.
>
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -133,6 +133,13 @@ else
> CFLAGS-$(CONFIG_GENERIC_CPU) += -mcpu=powerpc64
> endif
>
> +ifeq ($(CONFIG_PPC64),y)
> +ifdef CONFIG_HAVE_MPROFILE_KERNEL
> +CC_FLAGS_FTRACE := -pg $(call cc-option,-mprofile-kernel)
Do we want to define -pg even when -mprofile-kernel is not supported
by the used gcc, please?
> +KBUILD_CPPFLAGS += -DCC_USING_MPROFILE_KERNEL
IMHO, we should not define CC_USING_MPROFILE_KERNEL if it is not
supported by the compiler.
I took inspiration from the CC_USING_FENTRY handling in
linux/Makefile. The following code worked for me:
CC_USING_MPROFILE_KERNEL := $(call cc-option, -pg -mprofile-kernel -DCC_USING_MPROFILE_KERNEL)
CC_FLAGS_FTRACE := $(CC_USING_MPROFILE_KERNEL)
KBUILD_CPPFLAGS += $(CC_USING_MPROFILE_KERNEL)
I just do not understand why we need to add the flags also
to KBUILD_CPPFLAGS. It seems that they are duplicated
when compiling kernel/livepatch/core.o. But livepatching
did not work without it. I wonder if you found the culprit.
Best Regards,
Petr
> +endif
> +endif
> +
> CFLAGS-$(CONFIG_CELL_CPU) += $(call cc-option,-mcpu=cell)
> CFLAGS-$(CONFIG_POWER4_CPU) += $(call cc-option,-mcpu=power4)
> CFLAGS-$(CONFIG_POWER5_CPU) += $(call cc-option,-mcpu=power5)
next prev parent reply other threads:[~2015-12-03 16:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 16:53 [PATCH v4 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Torsten Duwe
2015-11-25 16:23 ` [PATCH v4 1/9] ppc64 (le): prepare for -mprofile-kernel Torsten Duwe
2015-11-26 10:12 ` Denis Kirjanov
2015-11-26 12:57 ` Torsten Duwe
2015-11-25 16:34 ` [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation Torsten Duwe
2015-11-26 10:04 ` Denis Kirjanov
2015-11-26 12:59 ` Torsten Duwe
2015-12-01 17:29 ` Torsten Duwe
2015-12-01 22:18 ` Michael Ellerman
2016-01-05 15:58 ` Torsten Duwe
2016-01-18 22:22 ` Jiri Kosina
2016-01-18 23:29 ` Michael Ellerman
2015-11-25 16:35 ` [PATCH v4 3/9] ppc use ftrace_modify_all_code default Torsten Duwe
2015-11-25 16:37 ` [PATCH v4 4/9] ppc64 ftrace_with_regs configuration variables Torsten Duwe
2015-12-03 16:20 ` Petr Mladek [this message]
2015-12-04 9:01 ` Torsten Duwe
2015-11-25 16:39 ` [PATCH v4 5/9] ppc64 ftrace_with_regs: spare early boot and low level Torsten Duwe
2015-11-25 16:41 ` [PATCH v4 6/9] ppc64 ftrace: disable profiling for some functions Torsten Duwe
2015-11-25 16:42 ` [PATCH v4 7/9] ppc64 ftrace: disable profiling for some files Torsten Duwe
2015-11-25 16:48 ` [PATCH v4 8/9] Implement kernel live patching for ppc64le (ABIv2) Torsten Duwe
2015-12-03 16:24 ` Petr Mladek
2015-12-04 9:06 ` Torsten Duwe
2015-11-25 16:49 ` [PATCH v4 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected Torsten Duwe
2015-12-03 16:00 ` [PATCH v4 0/9] ftrace with regs + live patching for ppc64 LE (ABI v2) Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151203162008.GF8047@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=duwe@lst.de \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).